Skip to content

Commit 9cd540f

Browse files
committed
- subtitle dialog code refactor
1 parent a48ac5b commit 9cd540f

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/main/java/mediathek/gui/dialog/subripmerge/MergeSubripVideoDialog.java

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public MergeSubripVideoDialog(Window owner) {
5656
btnMerge.setEnabled(false);
5757

5858
fillLanguageComboBox();
59+
cbLanguage.setSelectedItem(getLanguageText(LanguageCode.de));
5960

6061
btnCancel.addActionListener(_ -> dispose());
6162

@@ -79,13 +80,19 @@ public MergeSubripVideoDialog(Window owner) {
7980
if (file != null) {
8081
tfVideoFilePath.setText(file.getAbsolutePath());
8182
}
83+
else {
84+
tfVideoFilePath.setText("");
85+
}
8286
});
8387

8488
btnSelectVideoOutputPath.addActionListener(_ -> {
8589
var file = FileDialogs.chooseSaveFileLocation(this, "Videospeicherort wählen", "");
8690
if (file != null) {
8791
tfVideoOutputPath.setText(file.getAbsolutePath());
8892
}
93+
else {
94+
tfVideoOutputPath.setText("");
95+
}
8996
});
9097

9198
btnMerge.addActionListener(_ -> {
@@ -176,11 +183,14 @@ private void shutdownMergeProcess() {
176183
btnCancel.setEnabled(true);
177184
}
178185

186+
private String getLanguageText(LanguageCode code) {
187+
return String.format("%s [%s]", code.nativeName(), code.getISO3Language());
188+
}
189+
179190
public void fillLanguageComboBox() {
180191
List<String> languages = new ArrayList<>();
181192
for (var item : LanguageCode.values()) {
182-
var entry = String.format("%s [%s]", item.nativeName(), item.getISO3Language());
183-
languages.add(entry);
193+
languages.add(getLanguageText(item));
184194
}
185195
cbLanguage.setModel(new DefaultComboBoxModel<>(languages.toArray(new String[0])));
186196
}
@@ -225,13 +235,19 @@ private void initComponents() {
225235
label1.setText("Untertitel-Datei:"); //NON-NLS
226236
label1.setHorizontalAlignment(SwingConstants.RIGHT);
227237

238+
//---- tfSubripFilePath ----
239+
tfSubripFilePath.setToolTipText("Pfad zur Untertiteldatei im Subrip Text Format (.srt)"); //NON-NLS
240+
228241
//---- btnSelectInputSubrip ----
229242
btnSelectInputSubrip.setText("..."); //NON-NLS
230243

231244
//---- label2 ----
232245
label2.setText("Video-Datei:"); //NON-NLS
233246
label2.setHorizontalAlignment(SwingConstants.RIGHT);
234247

248+
//---- tfVideoFilePath ----
249+
tfVideoFilePath.setToolTipText("Pfad zu einer von ffmpeg unterst\u00fctzten Videodatei als Eingabemedium"); //NON-NLS
250+
235251
//---- btnSelectInputVideo ----
236252
btnSelectInputVideo.setText("..."); //NON-NLS
237253

src/main/java/mediathek/gui/dialog/subripmerge/MergeSubripVideoDialog.jfd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ new FormModel {
3232
} )
3333
add( new FormComponent( "javax.swing.JTextField" ) {
3434
name: "tfSubripFilePath"
35+
"toolTipText": "Pfad zur Untertiteldatei im Subrip Text Format (.srt)"
3536
} )
3637
add( new FormComponent( "javax.swing.JButton" ) {
3738
name: "btnSelectInputSubrip"
@@ -47,6 +48,7 @@ new FormModel {
4748
} )
4849
add( new FormComponent( "javax.swing.JTextField" ) {
4950
name: "tfVideoFilePath"
51+
"toolTipText": "Pfad zu einer von ffmpeg unterstützten Videodatei als Eingabemedium"
5052
} )
5153
add( new FormComponent( "javax.swing.JButton" ) {
5254
name: "btnSelectInputVideo"

0 commit comments

Comments
 (0)