Skip to content

Change in the metrics request url and updated API version. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change in the metrics request url and updated API version. #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50889d3
Change in the metrics request url.
blaaaaab May 27, 2019
f9daef0
Changed API version to 2018-01-01
blaaaaab Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions check_azure_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class NagiosAzureResourceMonitor(Plugin):
"""Implements functionalities to grab metrics from Azure resource objects."""

DEFAULT_AZURE_SERVICE_HOST = 'management.azure.com'
_AZURE_METRICS_API = '2017-05-01-preview'
_AZURE_METRICS_API = '2018-01-01'
_AZURE_METRICS_UNIT_SYMBOLS = {'Percent': '%', 'Bytes': 'B', 'Seconds': 's'}

def __init__(self, *args, **kwargs):
Expand Down Expand Up @@ -166,12 +166,11 @@ def _is_dimension_required(self):
def _get_metric_value(self):
"""Get latest metric value available for the Azure resource object."""

query = {'metric': self['metric']}
query = {'metricnames': self['metric']}
if self['dimension'] is not None:
query['$filter'] = "{} eq '{}'".format(self['dimension'], self['dimension-value'])

path = '{}/providers/Microsoft.Insights/metrics/{}'.format(self['resource'],
self['metric'])
path = '{}/providers/Microsoft.Insights/metrics/'.format(self['resource'])

try:
metric_values = _call_arm_rest_api(self._client, path,
Expand Down