Skip to content

CI: package-lint optional dependency issues (which-key) #743

@eshrh

Description

@eshrh

CI error:
Error: You should depend on (emacs "30.1") if you need `which-key--create-buffer-and-show'.

which-key was added to emacs 30.

Relevant (?):

  • meow/meow-shims.el

    Lines 389 to 408 in e5817f3

    (defvar which-key-mode)
    (declare-function which-key--create-buffer-and-show "which-key"
    (&optional prefix-keys from-keymap filter prefix-title))
    (defvar meow--which-key-setup nil)
    (defun meow--which-key-describe-keymap ()
    "Use which-key for keypad popup."
    (if which-key-mode
    (setq
    which-key-use-C-h-commands nil
    meow-keypad-describe-keymap-function
    (lambda (keymap)
    (which-key--create-buffer-and-show nil keymap nil (concat meow-keypad-message-prefix (meow--keypad-format-keys))))
    meow-keypad-clear-describe-keymap-function 'which-key--hide-popup)
    (setq meow-keypad-describe-keymap-function 'meow-describe-keymap
    meow-keypad-clear-describe-keymap-function nil
    which-key-use-C-h-commands t)))
  • Being told that transient should depend on a newer emacs or transient purcell/package-lint#281
  • Allow ignoring of errors purcell/package-lint#125
    • purcell seems to be of the opinion that you should put each shim into a different, small package. I'm honestly inclined to agree, but it obviously involves a nonzero amount of more work.

Either way, something needs to be done about the package-lint error... recent commit (a159b74) was a naive attempt to quickly silence the problem but I quickly realized there's a bigger problem here. Warrants more discussion, hence this issue.

package-lint also doesn't like all the eval-after-loads in the shims but that's a different problem (or maybe not, idk)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions