Implement __str__ for Point struct py binding (#977)

Summary:
Pull Request resolved: #977

Implement `__str__` method for the `Point` struct in the `monarch_hyperactor` library. The `__str__` method returns a string representation of the `Point` struct, which includes the labels and coordinates of the point.

Also, added a unit test for the same.

Related github issue #935

TODO: Plan to audit other structs with missing __str__. If there are missing ones, then those shall be sent via separate diff.

Reviewed By: highker

Differential Revision: D80862068

fbshipit-source-id: 11af7638fe49feeba5102e8af66d87370396d5af

Author: pankit-eng

monarch_hyperactor/src/shape.rs

@@ -210,6 +210,31 @@ impl PyPoint {
         }
     }
 
+    fn __str__(&self, py: Python) -> PyResult<String> {
+        let shape = self.shape.bind(py).get();
+        let inner_shape = &shape.inner;
+        let slice = inner_shape.slice();
+        let total_size = slice.len();
+        let current_rank = self.rank;
+
+        let coords = slice
+            .coordinates(current_rank)
+            .map_err(|e| PyErr::new::<PyValueError, _>(e.to_string()))?;
+
+        // Create the underlying Point struct from ndslice::view
+        let extent =
+            ndslice::view::Extent::new(inner_shape.labels().to_vec(), slice.sizes().to_vec())
+                .map_err(|e| PyErr::new::<PyValueError, _>(e.to_string()))?;
+        let point = extent
+            .point(coords)
+            .map_err(|e| PyErr::new::<PyValueError, _>(e.to_string()))?;
+
+        Ok(format!(
+            "rank={}/{} coords={{{}}}",
+            current_rank, total_size, point
+        ))
+    }
+
     fn __repr__(&self, py: Python) -> PyResult<String> {
         let shape = self.shape.bind(py).get();
         let inner_shape = &shape.inner;
@@ -234,6 +259,7 @@ impl PyPoint {
 
         let coords_str = coords_parts.join(",");
 
+        // TODO: Should we call the Display implementation of the Point struct using extent here as well?
         Ok(format!(
             "rank={}/{} coords={{{}}}",
             current_rank, total_size, coords_str

ndslice/src/view.rs

@@ -370,7 +370,13 @@ impl std::fmt::Display for Point {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let n = self.coords.len();
         for i in 0..n {
-            write!(f, "{}={}", self.extent.labels()[i], self.coords[i])?;
+            write!(
+                f,
+                "{}={}/{}",
+                self.extent.labels()[i],
+                self.coords[i],
+                self.extent.sizes()[i]
+            )?;
             if i != n - 1 {
                 write!(f, ",")?;
             }
@@ -851,7 +857,7 @@ mod test {
     fn test_point_display() {
         let extent = Extent::new(vec!["x".into(), "y".into(), "z".into()], vec![4, 5, 6]).unwrap();
         let point = extent.point(vec![1, 2, 3]).unwrap();
-        assert_eq!(format!("{}", point), "x=1,y=2,z=3");
+        assert_eq!(format!("{}", point), "x=1/4,y=2/5,z=3/6");
 
         assert!(extent.point(vec![]).is_err());
 

python/monarch/_rust_bindings/monarch_hyperactor/shape.pyi

@@ -106,7 +106,7 @@ class Shape:
 
     Arguments:
     - `labels`: A list of strings representing the labels for each dimension.
-    - `slice`: An Slice object representing the shape.
+    - `slice`: A Slice object representing the shape.
     """
     def __new__(cls, labels: Sequence[str], slice: Slice) -> "Shape": ...
     @property

python/tests/_monarch/test_ndslice.py

@@ -12,7 +12,7 @@
 
 from monarch._rust_bindings.monarch_hyperactor.selection import Selection
 
-from monarch._rust_bindings.monarch_hyperactor.shape import Shape, Slice
+from monarch._rust_bindings.monarch_hyperactor.shape import Point, Shape, Slice
 
 
 class TestNdslice(TestCase):
@@ -191,6 +191,23 @@ def test_shape_repr(self) -> None:
         )
 
 
+class TestPoint(TestCase):
+    def test_point_str_simple(self) -> None:
+        """Test __str__ method for Point with simple 2D shape."""
+        s = Slice(offset=0, sizes=[3, 4], strides=[4, 1])
+        shape = Shape(["label0", "label1"], s)
+
+        # Test different ranks and their string representations
+        point_0 = Point(0, shape)
+        self.assertEqual(str(point_0), "rank=0/12 coords={label0=0/3,label1=0/4}")
+
+        point_3 = Point(3, shape)
+        self.assertEqual(str(point_3), "rank=3/12 coords={label0=0/3,label1=3/4}")
+
+        point_11 = Point(11, shape)
+        self.assertEqual(str(point_11), "rank=11/12 coords={label0=2/3,label1=3/4}")
+
+
 class TestSelection(TestCase):
     def test_constants(self) -> None:
         self.assertEqual(repr(Selection.any()), "Any(True)")