Skip to content

Commit 9597814

Browse files
committed
Build: Really test on Firefox ESR, new & old
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquerygh-597 Ref jquery/jquery#5682
1 parent 8b1fb5c commit 9597814

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

.github/workflows/browser-tests.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@ env:
1212
jobs:
1313
test:
1414
runs-on: ubuntu-latest
15-
name: ${{ matrix.BROWSER }} (${{ matrix.MIGRATE_VERSION }} Migrate)
15+
name: ${{ matrix.NAME || matrix.BROWSER }} (${{ matrix.MIGRATE_VERSION }} Migrate)
1616
strategy:
1717
fail-fast: false
1818
matrix:
19+
NAME: [""]
1920
BROWSER: ["chrome", "firefox"]
2021
MIGRATE_VERSION: ["min"]
2122
include:
22-
- NAME: "Node"
23+
- NAME: ""
2324
BROWSER: "chrome"
2425
MIGRATE_VERSION: "esmodules"
2526
- NAME: "Firefox ESR (new)"
@@ -57,7 +58,13 @@ jobs:
5758

5859
- name: Install Firefox ESR
5960
run: |
60-
wget --no-verbose $FIREFOX_SOURCE_URL -O - | tar -jx -C ${HOME}
61+
# Support: Firefox <135 only
62+
# Older Firefox used to be compressed using bzip2, newer using xz. Try
63+
# to uncompress using xz, fall back to bzip2 if that fails.
64+
# Note: this will download the old Firefox ESR twice, but it will still work
65+
# when the current ESR version starts to use xz with no changes to the code.
66+
wget --no-verbose "$FIREFOX_SOURCE_URL" -O - | tar -Jx -C "$HOME" || \
67+
wget --no-verbose "$FIREFOX_SOURCE_URL" -O - | tar -jx -C "$HOME"
6168
echo "PATH=${HOME}/firefox:$PATH" >> "$GITHUB_ENV"
6269
echo "FIREFOX_BIN=${HOME}/firefox/firefox" >> "$GITHUB_ENV"
6370
if: contains(matrix.NAME, 'Firefox ESR')

0 commit comments

Comments
 (0)