Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

orgList is not remapped to lowercase when changing via PATCH route #178

Open
#179
Open
orgList is not remapped to lowercase when changing via PATCH route#178
#179
@k----n

Description

@k----n
k----n
opened on Mar 22, 2020

The problem lies here:

ghcrawler/lib/crawler.js

Lines 30 to 37 in 0ac1107

_reconfigure(current, changes) {
// ensure the orgList is always lowercase
const orgList = changes.find(patch => patch.path === '/orgList');
if (orgList) {
debug('orgList changed');
this.options.orgList = orgList.value.map(element => element.toLowerCase());
}
}

The path is not only /orgList

ghcrawler/lib/crawler.js

Line 32 in 0ac1107

const orgList = changes.find(patch => patch.path === '/orgList');

When reassigning this.options.orgList, this.options.orgList.map(element => element.toLowerCase()) should be used and not orgList.value.map(element => element.toLowerCase()).

ghcrawler/lib/crawler.js

Line 35 in 0ac1107

this.options.orgList = orgList.value.map(element => element.toLowerCase());

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions