From cadd1a9b5da69db3cd3a69df4b053ae3228e24cb Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Oct 2025 14:03:23 -0700 Subject: [PATCH 1/4] devops: run webkit wsl tests --- .github/workflows/tests_webkit_wsl.yml | 72 ++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 .github/workflows/tests_webkit_wsl.yml diff --git a/.github/workflows/tests_webkit_wsl.yml b/.github/workflows/tests_webkit_wsl.yml new file mode 100644 index 0000000000000..4ff2216a722dc --- /dev/null +++ b/.github/workflows/tests_webkit_wsl.yml @@ -0,0 +1,72 @@ +name: Tests @ WebKit WSL + +on: + push: + branches: + - main + - release-* + pull_request: + paths-ignore: + - 'browser_patches/**' + - 'docs/**' + - 'packages/playwright/src/mcp/**' + - 'tests/mcp/**' + branches: + - main + - release-* + workflow_dispatch: + +env: + # Force terminal colors. @see https://www.npmjs.com/package/colors + FORCE_COLOR: 1 + +jobs: + test_webkit_wsl: + name: "Tests @ WebKit WSL ${{ matrix.headed && '(headed)' || '' }}" + runs-on: ["self-hosted", "1ES.Pool=DevDivPlaywrightWindows11"] + strategy: + fail-fast: false + matrix: + headed: [true, false] + permissions: + id-token: write # This is required for OIDC login (azure/login) to succeed + contents: read # This is required for actions/checkout to succeed + steps: + - uses: actions/checkout@v5 + - uses: actions/setup-node@v6 + with: + node-version: 20 + # TODO: This should be part of the self-hosted runner image, I'm working on fixing it in the image. + # See https://github.com/microsoft/playwright/issues/37036 + - name: Prefer Git Bash over WSL bash + shell: powershell + run: echo "C:\Program Files\Git\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + - name: Enable WSL2 networkingMode=mirrored + run: | + Add-Content -Path $env:USERPROFILE\.wslconfig -Value "[wsl2]`nnetworkingMode=mirrored" + - run: npm ci + env: + DEBUG: pw:install + PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 + - run: npm run build + - run: npx playwright install webkit-wsl ffmpeg + - name: Run tests + run: npm run wtest -- ${{ matrix.headed && '--headed' || '' }} + env: + PWTEST_CHANNEL: webkit-wsl + PWTEST_MODE: wsl + - name: Azure Login + if: always() + uses: azure/login@v2 + with: + client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} + tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} + subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} + - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json + if: always() + shell: bash + - uses: actions/upload-artifact@v5 + if: ${{ always() }} + with: + name: webkit-wsl-${{ matrix.headed && 'headed' || 'headless' }}-results + path: test-results From 4204467918c47c6d8e13c47098dfff3fb32d3dc7 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Oct 2025 14:06:59 -0700 Subject: [PATCH 2/4] run on windows latest, 1es pool is not supported --- .github/workflows/tests_webkit_wsl.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_webkit_wsl.yml b/.github/workflows/tests_webkit_wsl.yml index 4ff2216a722dc..c8323cf1f6f7b 100644 --- a/.github/workflows/tests_webkit_wsl.yml +++ b/.github/workflows/tests_webkit_wsl.yml @@ -23,7 +23,7 @@ env: jobs: test_webkit_wsl: name: "Tests @ WebKit WSL ${{ matrix.headed && '(headed)' || '' }}" - runs-on: ["self-hosted", "1ES.Pool=DevDivPlaywrightWindows11"] + runs-on: windows-latest strategy: fail-fast: false matrix: From 6f570351519c1811a1b6a9cda4d171272d591120 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Oct 2025 14:24:57 -0700 Subject: [PATCH 3/4] update WSL --- .github/workflows/tests_webkit_wsl.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/tests_webkit_wsl.yml b/.github/workflows/tests_webkit_wsl.yml index c8323cf1f6f7b..5d5d6d61948b9 100644 --- a/.github/workflows/tests_webkit_wsl.yml +++ b/.github/workflows/tests_webkit_wsl.yml @@ -41,6 +41,13 @@ jobs: - name: Prefer Git Bash over WSL bash shell: powershell run: echo "C:\Program Files\Git\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + - name: Update WSL2 to latest version + run: | + wsl --version + wsl --update + wsl --shutdown + wsl + shell: powershell - name: Enable WSL2 networkingMode=mirrored run: | Add-Content -Path $env:USERPROFILE\.wslconfig -Value "[wsl2]`nnetworkingMode=mirrored" From faa284ef54796c8d3d43c3db3842debb94851429 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Oct 2025 16:57:03 -0700 Subject: [PATCH 4/4] revert --- .github/workflows/tests_webkit_wsl.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/tests_webkit_wsl.yml b/.github/workflows/tests_webkit_wsl.yml index 5d5d6d61948b9..c8323cf1f6f7b 100644 --- a/.github/workflows/tests_webkit_wsl.yml +++ b/.github/workflows/tests_webkit_wsl.yml @@ -41,13 +41,6 @@ jobs: - name: Prefer Git Bash over WSL bash shell: powershell run: echo "C:\Program Files\Git\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append - - name: Update WSL2 to latest version - run: | - wsl --version - wsl --update - wsl --shutdown - wsl - shell: powershell - name: Enable WSL2 networkingMode=mirrored run: | Add-Content -Path $env:USERPROFILE\.wslconfig -Value "[wsl2]`nnetworkingMode=mirrored"