Skip to content

Commit 2c8bed2

Browse files
authored
Merge pull request #4463 from microsoft/octogonz/rush-missing-experiment
[rush] Update "rush init" template to document missing experiment
2 parents 2d96034 + 21ee982 commit 2c8bed2

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/rush",
5+
"comment": "Update `rush init` template to document the \"buildSkipWithAllowWarningsInSuccessfulBuild\" experiment",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@microsoft/rush"
10+
}

libraries/rush-lib/assets/rush-init/common/config/rush/experiments.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
*/
4444
/*[LINE "HYPOTHETICAL"]*/ "buildCacheWithAllowWarningsInSuccessfulBuild": true,
4545

46+
/**
47+
* If true, build skipping will respect the allowWarningsInSuccessfulBuild flag and skip builds with warnings.
48+
* This will not replay warnings from the skipped build.
49+
*/
50+
/*[LINE "HYPOTHETICAL"]*/ "buildSkipWithAllowWarningsInSuccessfulBuild": true,
51+
4652
/**
4753
* If true, the phased commands feature is enabled. To use this feature, create a "phased" command
4854
* in common/config/rush/command-line.json.

libraries/rush-lib/src/api/ExperimentsConfiguration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ import schemaJson from '../schemas/experiments.schema.json';
1313
export interface IExperimentsJson {
1414
/**
1515
* By default, 'rush install' passes --no-prefer-frozen-lockfile to 'pnpm install'.
16-
* Set this option to true to pass '--frozen-lockfile' instead.
16+
* Set this option to true to pass '--frozen-lockfile' instead for faster installs.
1717
*/
1818
usePnpmFrozenLockfileForRushInstall?: boolean;
1919

2020
/**
2121
* By default, 'rush update' passes --no-prefer-frozen-lockfile to 'pnpm install'.
22-
* Set this option to true to pass '--prefer-frozen-lockfile' instead.
22+
* Set this option to true to pass '--prefer-frozen-lockfile' instead to minimize shrinkwrap changes.
2323
*/
2424
usePnpmPreferFrozenLockfileForRushUpdate?: boolean;
2525

0 commit comments

Comments
 (0)