TOM _model.py - add_role_member for Groups

[gasperzerak]

Dear all,

i was trying to use it to add sec. Groups to the security roles of the semantic model, which would make more sense in the enterprise environment. As far as i saw it implements only adding "emails", meaning user(s). Is there any plan to add it, or is it even possible to add it with current function.

I have seen there is RoleMemberType for this use-case.

As i try to use the security groups instead of member i am getting:

OperationException: Failed to save modifications to the server. Error returned: 'There are invalid rolememberships in roles, please remove invalid rolememberships from roles and try again.

Thanks and regards

[m-kovalsky]

Created a PR to fix this issue. The PR adds a 'role_member_type' parameter which defaults to 'User' but can be set to 'Group' to allow you to add groups as members of roles. This will be available in the next release.

[GitBen-dorid]

Hi Thank you for this fix.

I have tried to run this, this morning and I am getting the same error as above.

OperationException: Failed to save modifications to the server. Error returned: 'There are invalid rolememberships in roles, please remove invalid rolememberships from roles and try again.

I am using Azure Cloud Security groups and currently I have tried using the group name and the object ID but still getting the same error.

[behram-kn]

Hi @m-kovalsky ,I'm encountering the same issue. The examples provided use an email address for the group, but groups don't have email addresses. I've tried using the group name and the object ID, but neither seems to work.

https://github.com/microsoft/semantic-link-labs/wiki/Code-Examples#set-roles-members-and-row-level-security-rls

[justinsweet]

@m-kovalsky I tried User and Group and getting same error as above for security groups. Emails seem to work fine but SG have no email address and keep getting exception: There are invalid rolememberships in roles, please remove invalid rolememberships from roles and try again.

[m-kovalsky]

See the resolution here.

[justinsweet]

that worked, thank you so much!