[vcpkg/scripts] WSL2 minor issue in bootstrapping script

[workpadwan]

Hi,

I am trying to get vcpkg to work on WSL2 @ work and found some warnings/errors when running the script
./bootstrap-vcpkg.sh
The error I get repeats as follows:

./bootstrap-vcpkg.sh: 168: /path/vcpkg/scripts/bootstrap.sh: [[: not found

So I checked the script and it is indeed the script
scripts/bootstrap.sh at row 168

The code looks like follows there:

if [ "$toolData" = "" ] || [[ "$toolData" == "<?xml"* ]]; then
    echo "No entry for $toolRegexStart in $vcpkgRootDir/scripts/vcpkgTools.xml"
    return 1
fi

However this will not work since the script is using shell (/bin/sh) and not bash.
One "fix" could be as follows but I bet someone who knows shell better than me can make it look prettier:

case "$toolData" in
    "<?xml"*)
        echo "No entry for $toolRegexStart in $vcpkgRootDir/scripts/vcpkgTools.xml"
        return 1 ;;
esac
if [ "$toolData" = "" ]; then
    echo "No entry for $toolRegexStart in $vcpkgRootDir/scripts/vcpkgTools.xml"
    return 1
fi

This will make the warnings/errors disappear when I run the script but I will leave this as a suggestion for someone else to decide....

Cheers,

[autoantwort]

Hm seems that I have introduced that with #19640. We can do that or change the shebang to /bin/bash.

[talregev]

https://stackoverflow.com/questions/3401183/bash-syntax-error-not-found

[BillyONeal]

Because @workpadwan submitted a perfectly good fix that doesn't require it

[BillyONeal]

#19911 Thanks for the fix. Do you want to submit your own PR so that you have "credit" for the merged PR since you in effect authored the fix?

[workpadwan]

@BillyONeal It's ok, just submit/commit it... I'm not that much of a poster boy.

[BillyONeal]

@BillyONeal It's ok, just submit/commit it... I'm not that much of a poster boy.

Thanks! Landed.

[talregev]

It happen to me too. Please fix.