Skip to content

Commit 023a585

Browse files
committed
Fix WhereIn on empty data sets
1 parent 98543fa commit 023a585

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

tests/Integration/CachedBuilder/WhereInTest.php

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,13 @@
11
<?php namespace GeneaLabs\LaravelModelCaching\Tests\Integration\CachedBuilder;
22

3-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Author;
43
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Book;
5-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Profile;
6-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Publisher;
7-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Store;
84
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedAuthor;
95
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedBook;
10-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedProfile;
11-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedPublisher;
12-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedStore;
13-
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Http\Resources\Author as AuthorResource;
146
use GeneaLabs\LaravelModelCaching\Tests\IntegrationTestCase;
15-
use Illuminate\Foundation\Testing\RefreshDatabase;
16-
use Illuminate\Support\Collection;
177

188
class WhereInTest extends IntegrationTestCase
199
{
20-
public function testWithInUsingCollectionQuery()
10+
public function testWhereInUsingCollectionQuery()
2111
{
2212
$key = sha1('genealabs:laravel-model-caching:testing::memory::books:genealabslaravelmodelcachingtestsfixturesbook-author_id_in_1_2_3_4');
2313
$tags = [
@@ -42,8 +32,8 @@ public function testWithInUsingCollectionQuery()
4232
$this->assertEquals($liveResults->pluck("id"), $cachedResults->pluck("id"));
4333
}
4434

45-
46-
public function testWithInWhenSetIsEmpty()
35+
/** @group test */
36+
public function testWhereInWhenSetIsEmpty()
4737
{
4838
$key = sha1('genealabs:laravel-model-caching:testing::memory::books:genealabslaravelmodelcachingtestsfixturesbook-author_id_in_1_2_3_4');
4939
$tags = [
@@ -57,9 +47,9 @@ public function testWithInWhenSetIsEmpty()
5747
->whereIn("author_id", $authors)
5848
->get();
5949
$cachedResults = $this
60-
->cache()
61-
->tags($tags)
62-
->get($key)['value'];
50+
->cache()
51+
->tags($tags)
52+
->get($key)['value'];
6353
$liveResults = (new UncachedBook)
6454
->whereIn("author_id", $authors)
6555
->get();

0 commit comments

Comments
 (0)