Skip to content

Conversation

@Philipp91
Copy link
Contributor

No description provided.

@Philipp91 Philipp91 marked this pull request as draft November 10, 2025 22:25
@Philipp91
Copy link
Contributor Author

It currently fails to compile because:

exception: caused by: org.jetbrains.org.objectweb.asm.MethodTooLargeException: Method too large: com/mikepenz/iconics/typeface/library/materialsymbols/OutlinedMaterialSymbols$Icon.<clinit> ()V
exception: 	at org.jetbrains.org.objectweb.asm.MethodWriter.computeMethodInfoSize(MethodWriter.java:2087)
exception: 	at org.jetbrains.org.objectweb.asm.ClassWriter.toByteArray(ClassWriter.java:489)
exception: 	at org.jetbrains.kotlin.codegen.ClassBuilderFactories$2.asBytes(ClassBuilderFactories.java:118)
exception: 	at org.jetbrains.kotlin.codegen.DelegatingClassBuilderFactory.asBytes(DelegatingClassBuilderFactory.kt:36)
exception: 	at org.jetbrains.kotlin.codegen.DelegatingClassBuilderFactory.asBytes(DelegatingClassBuilderFactory.kt:36)
exception: 	at org.jetbrains.kotlin.codegen.ClassFileFactory$ClassBuilderAndSourceFileList.asBytes(ClassFileFactory.java:358)
exception: 	at org.jetbrains.kotlin.codegen.ClassFileFactory$OutputClassFile.asByteArray(ClassFileFactory.java:322)
exception: 	... 25 more
exception: 

I guess the 4000-ish lines of code in a single enum are too much for the Kotlin compiler.

Do you have any advice on how to fix this? We could have separate classes somehow, perhaps split into 4 sub-ranges by alphabet?

@mikepenz
Copy link
Owner

@Philipp91 thank you very much. And yes, splitting it into multiple enums is required.

See for example:

@mikepenz
Copy link
Owner

Also I'd really appreciate if you could follow the naming scheme already established for the icon set from google:
https://github.com/mikepenz/Android-Iconics/pull/654/files#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9R127-R128

@mikepenz
Copy link
Owner

The outlined one already exists: google-material-typeface-outlined-library but probably needs to be updated?

@Philipp91
Copy link
Contributor Author

Philipp91 commented Nov 11, 2025

The outlined one already exists: google-material-typeface-outlined-library

No that's something else. Those are the Material Icons (of which there are around 1400), whereas what I'm adding are the Material Symbols (of which there are around 4000 apparently). Both of them are published in the same GitHub repo:

These are two different official icon sets from Google, using the same underlying designs. Material Symbols is the current set, introduced in April 2022, built on variable font technology. Material Icons is the classic set, but no longer updated.


That's also why I broke with the naming scheme. But if you prefer, I can prefix google- everywhere, it's just that google-material-symbols-typeface-outlined-library is such a mouthful.

@mikepenz
Copy link
Owner

Ah! thanks for the clarification @Philipp91

@Philipp91
Copy link
Contributor Author

See for example

Thank you! I've now implemented it like that.

@Philipp91 Philipp91 marked this pull request as ready for review November 12, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants