-
-
Notifications
You must be signed in to change notification settings - Fork 616
Add Google Material Symbols #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
It currently fails to compile because: I guess the 4000-ish lines of code in a single Do you have any advice on how to fix this? We could have separate classes somehow, perhaps split into 4 sub-ranges by alphabet? |
|
@Philipp91 thank you very much. And yes, splitting it into multiple enums is required. See for example: Line 2735 in 9109ca1
|
|
Also I'd really appreciate if you could follow the naming scheme already established for the icon set from google: |
|
The outlined one already exists: |
No that's something else. Those are the Material Icons (of which there are around 1400), whereas what I'm adding are the Material Symbols (of which there are around 4000 apparently). Both of them are published in the same GitHub repo:
That's also why I broke with the naming scheme. But if you prefer, I can prefix |
|
Ah! thanks for the clarification @Philipp91 |
4bc39d8 to
2947b50
Compare
Thank you! I've now implemented it like that. |
No description provided.