From cd155d9f445e864871058c2d0e37b066f3fd28c3 Mon Sep 17 00:00:00 2001 From: Tristan McKinney Date: Wed, 18 Jun 2025 10:32:41 -0700 Subject: [PATCH 1/4] Fix compatibility with polymode after pm--visible-buffer-name removal Replace pm--visible-buffer-name with pm--buffer-name to maintain compatibility with polymode commit 32d0d6d which removed the pm--visible-buffer-name function and replaced it with pm--buffer-name. The pm--buffer-name function takes an optional 'hidden parameter: - pm--buffer-name() returns the visible buffer name (equivalent to old pm--visible-buffer-name) - pm--buffer-name('hidden) returns the hidden buffer name (equivalent to old pm--hidden-buffer-name) This change fixes the issue where ein would fail to load due to the undefined pm--visible-buffer-name function. Fixes compatibility with polymode >= commit 32d0d6d. --- lisp/poly-ein.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/poly-ein.el b/lisp/poly-ein.el index ca190aac..b770f22f 100644 --- a/lisp/poly-ein.el +++ b/lisp/poly-ein.el @@ -351,13 +351,13 @@ TYPE can be \\='body, nil." (apply-partially #'poly-ein--narrow-to-inner #'identity)))) (defun poly-ein--record-window-buffer () - "(pm--visible-buffer-name) needs to get onto window's prev-buffers. + "(pm--buffer-name) needs to get onto window's prev-buffers. But `C-x b` seems to consult `buffer-list' and not the C (window)->prev_buffers." (when (buffer-base-buffer) (let* ((buffer-list (frame-parameter nil 'buffer-list)) (pos-visible (seq-position buffer-list - (pm--visible-buffer-name) + (pm--buffer-name) (lambda (x visible*) (string-prefix-p (buffer-name x) visible*))))) ;; no way to know if i've switched in or out of indirect buf. @@ -382,7 +382,7 @@ But `C-x b` seems to consult `buffer-list' and not the C (window)->prev_buffers. (add-hook 'ido-make-buffer-list-hook (lambda () (defvar ido-temp-list) - (when-let ((visible (pm--visible-buffer-name))) + (when-let ((visible (pm--buffer-name))) (ido-to-end (delq nil (mapcar (lambda (x) (when (string-prefix-p x visible) x)) From 0aa09c53a7d62957ce7b3fd4a0560a7553f2f15e Mon Sep 17 00:00:00 2001 From: Tristan McKinney Date: Wed, 18 Jun 2025 11:58:33 -0700 Subject: [PATCH 2/4] Fix deprecated GitHub Actions versions ### Notes - Update actions/checkout from v2 to v4 - Update actions/setup-python from v2 to v4 - Update actions/cache from v2 to v4 (both instances) ### Testing This addresses the workflow failure caused by deprecated action versions. The updated actions are the current stable releases and should resolve the CI pipeline issues. ### Issues * Fixes GitHub Actions deprecation warnings in CI workflow --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 56d46959..b9581165 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,10 +22,10 @@ jobs: python-version: [3.7] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} @@ -34,13 +34,13 @@ jobs: with: version: ${{ matrix.emacs_version }} - - uses: actions/cache@v2 + - uses: actions/cache@v4 id: cache-cask-packages with: path: .cask key: cache-cask-packages-001 - - uses: actions/cache@v2 + - uses: actions/cache@v4 id: cache-cask-executable with: path: ~/.cask From 83964893bef57fe73e2e2d6e76dce5efa8a5ae1f Mon Sep 17 00:00:00 2001 From: Tristan McKinney Date: Wed, 18 Jun 2025 12:02:46 -0700 Subject: [PATCH 3/4] Update Python version from 3.7 to 3.8 in CI workflow ### Notes - Change python-version from 3.7 to 3.8 in test matrix - Python 3.7 reached end-of-life and is no longer available on Ubuntu 24.04 - Python 3.8 is widely supported and compatible with the project requirements ### Testing This addresses the CI failure where Python 3.7 was not found in the local cache for Ubuntu 24.04. Python 3.8 should be available and allow the workflow to proceed. ### Issues * Fixes Python version availability issue in GitHub Actions workflow --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b9581165..7154ee32 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ jobs: matrix: os: [ubuntu-latest] emacs_version: [26.3, 27.2, 28.2, 29.1] - python-version: [3.7] + python-version: [3.8] steps: - uses: actions/checkout@v4 From 2ff01b4adbb6302798fc84464d1e420e337113fd Mon Sep 17 00:00:00 2001 From: Tristan McKinney Date: Wed, 18 Jun 2025 12:15:03 -0700 Subject: [PATCH 4/4] Remove Emacs 26.3 from CI test matrix ### Notes - Remove emacs_version 26.3 from test matrix - Keep testing on 27.2, 28.2, and 29.1 - Dependencies now require Emacs 27.1+ (magit and others have updated minimum requirements) ### Testing This addresses the CI failure where packages required Emacs 27.1 but the workflow was testing on 26.3. The remaining Emacs versions should be compatible with current package dependencies. ### Issues * Fixes Emacs version compatibility issue in GitHub Actions workflow --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7154ee32..f526676d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - emacs_version: [26.3, 27.2, 28.2, 29.1] + emacs_version: [27.2, 28.2, 29.1] python-version: [3.8] steps: