Skip to content

Commit ca70c06

Browse files
committed
more logging added temporarily
Signed-off-by: Patrick Casey <patrick.casey1@outlook.com>
1 parent efcd4e7 commit ca70c06

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

Cargo.lock

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hipcheck/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ gix = { version = "0.70.0", features = [
5151
"max-control",
5252
# use reqwest/rustls to avoid needing openssl
5353
"blocking-http-transport-reqwest-rust-tls",
54-
"zlib-stock"
54+
"zlib-stock",
55+
# TODO: remove this
56+
"tracing"
5557
] }
5658
# Include with both a `path` and `version` reference.
5759
# Local builds will use the `path` dependency, which may be a newer

hipcheck/src/target/resolve.rs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -248,22 +248,22 @@ impl ResolveRepo for RemoteGitRepo {
248248

249249
// NOTE: suspend_status is needed, otherwise the Shell ProgressBars and progress bars
250250
// tracking git operation progress fight over the terminal
251-
t.suspend_status(|| -> std::result::Result<(), crate::Error> {
252-
// when this goes out of scope, the render thread will die
253-
let progress_root = prodash::tree::Root::new();
254-
// do not drop this until the end of the scope, otherwise the render thread will die
255-
let _handle = GitProgressRenderHandle::new(progress_root.clone());
256-
257-
// Clone remote repo if not exists
258-
if path.exists().not() {
259-
git::clone(&self.url, &path, progress_root.clone())
260-
.context("failed to clone remote repository")?;
261-
}
262-
// Whether we cloned or not, we need to fetch so we get tags
263-
git::fetch(&path, progress_root.clone())
264-
.context("failed to fetch updates from remote repository")?;
265-
Ok(())
266-
})?;
251+
// t.suspend_status(|| -> std::result::Result<(), crate::Error> {
252+
// when this goes out of scope, the render thread will die
253+
let progress_root = prodash::tree::Root::new();
254+
// do not drop this until the end of the scope, otherwise the render thread will die
255+
let _handle = GitProgressRenderHandle::new(progress_root.clone());
256+
257+
// Clone remote repo if not exists
258+
if path.exists().not() {
259+
git::clone(&self.url, &path, progress_root.clone())
260+
.context("failed to clone remote repository")?;
261+
}
262+
// Whether we cloned or not, we need to fetch so we get tags
263+
git::fetch(&path, progress_root.clone())
264+
.context("failed to fetch updates from remote repository")?;
265+
// Ok(())
266+
// })?;
267267

268268
let refspec = t.get_checkout_target(&path)?;
269269
let git_ref = git::checkout(&path, refspec)?.to_string();

0 commit comments

Comments
 (0)