Skip to content

Autoharness include/exclude pattern does not support whitespace #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tautschnig opened this issue Apr 25, 2025 · 1 comment
Open

Autoharness include/exclude pattern does not support whitespace #4046

tautschnig opened this issue Apr 25, 2025 · 1 comment
Assignees
@carolynzech
Labels
[C] Bug This is a bug. Something isn't working. Z-Autoharness Issue related to autoharness subcommand

Comments

@tautschnig
Copy link
Member

See https://github.com/model-checking/verify-rust-std/actions/runs/14673784039/job/41186052310?pr=334: when trying to use something like --include-pattern "num::<impl i8>::wrapping_sh"
our splitting of RUSTFLAGS on whitespace in base_rustc_flags falls over.
@tautschnig tautschnig added the [C] Bug This is a bug. Something isn't working. label Apr 25, 2025
@carolynzech carolynzech self-assigned this Apr 28, 2025
@tautschnig
Copy link
Member Author

One way to work around the RUSTFLAGS parsing problem is to add regular expression support when handling --include-pattern (and --exclude-pattern) for we could then just use . or [[:space:]] instead of the literal whitespace.

@carolynzech carolynzech added the Z-Autoharness Issue related to autoharness subcommand label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolynzech carolynzech

Labels
[C] Bug This is a bug. Something isn't working. Z-Autoharness Issue related to autoharness subcommand
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tautschnig @carolynzech