Skip to content

Commit d33a4e4

Browse files
committed
Internal fix for creating Docker image.
1 parent 17b9439 commit d33a4e4

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

HISTORY.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
=======
22
History
33
=======
4+
2024.5.23.1 -- Internal fix for creating Docker image.
5+
46
2024.5.23 -- Added standard energy and gradients to results
57
* Added 'energy' and 'gradients' to optional results to support e.g. Energy Scan
68
* Fixed crashing bug in description of the Energy substep.

Makefile

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
MODULE := psi4_step
22
.PHONY: help clean clean-build clean-docs clean-pyc clean-test lint format typing test
33
.PHONY: dependencies test-all coverage html docs servedocs release check-release
4-
.PHONY: dist install uninstall
4+
.PHONY: dist install uninstall image uninstall-image
55
.DEFAULT_GOAL := help
6+
67
define BROWSER_PYSCRIPT
78
import os, webbrowser, sys
89
try:
@@ -12,6 +13,7 @@ except:
1213

1314
webbrowser.open("file://" + pathname2url(os.path.abspath(sys.argv[1])))
1415
endef
16+
1517
export BROWSER_PYSCRIPT
1618

1719
define PRINT_HELP_PYSCRIPT
@@ -23,7 +25,9 @@ for line in sys.stdin:
2325
target, help = match.groups()
2426
print("%-20s %s" % (target, help))
2527
endef
28+
2629
export PRINT_HELP_PYSCRIPT
30+
2731
BROWSER := python -c "$$BROWSER_PYSCRIPT"
2832

2933
help:
@@ -59,20 +63,16 @@ format: ## reformat with with yapf and isort
5963
black --extend-exclude '_version.py' $(MODULE) tests
6064

6165
test: ## run tests quickly with the default Python
62-
pytest tests/
66+
pytest --doctest-modules tests $(MODULE)
6367

64-
coverage: ## check code coverage quickly with the default Python
65-
pytest -v --cov=$(MODULE) --cov-report term --color=yes tests/
68+
dependencies:
69+
pur -r requirements_dev.txt
70+
pip install -r requirements_dev.txt
6671

67-
coverage-html: ## check code coverage quickly with the default Python, showing as html
68-
pytest -v --cov=$(MODULE) --cov-report=html:htmlcov --cov-report term --color=yes tests/
72+
coverage: clean-test ## check code coverage quickly with the default Python
73+
pytest -v --doctest-modules --cov=$(MODULE) --cov-report=html tests/ $(MODULE)
6974
$(BROWSER) htmlcov/index.html
7075

71-
clean-docs: ## remove files associated with building the docs
72-
rm -f docs/api/$(MODULE).rst
73-
rm -f docs/api/modules.rst
74-
$(MAKE) -C docs clean
75-
7676
html: clean-docs ## generate Sphinx HTML documentation, including API docs
7777
sphinx-apidoc -o docs/api $(MODULE)
7878
$(MAKE) -C docs html
@@ -100,3 +100,9 @@ install: uninstall ## install the package to the active Python's site-packages
100100

101101
uninstall: clean ## uninstall the package
102102
pip uninstall --yes $(MODULE)
103+
104+
image: uninstall-image ## Make the Docker image
105+
docker image build --progress plain --file devtools/docker/Dockerfile --tag ghcr.io/molssi-seamm/seamm-psi4:latest .
106+
107+
uninstall-image: ## Remove the docker image
108+
docker image rm --force ghcr.io/molssi-seamm/seamm-psi4:latest

devtools/docker/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
FROM molssi/mamba141
22

3-
COPY ./environment.yml /root/environment.yml
3+
COPY ./psi4_step/data/seamm-psi4.yml /root/environment.yml
44

55
RUN mamba env update -f /root/environment.yml
66

77
WORKDIR /home
8-
CMD ["psi4", "mopac.dat"]
8+
CMD ["psi4"]

devtools/docker/environment.yml

Lines changed: 0 additions & 8 deletions
This file was deleted.

psi4_step/data/seamm-psi4.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ channels:
33
- conda-forge
44
- conda-forge/label/libint_dev
55
dependencies:
6-
- geometric
76
- python
7+
88
# Executables, etc.
9+
- geometric
910
- psi4
10-
# - psi4-rt

0 commit comments

Comments
 (0)