Skip to content

Commit e12bde0

Browse files
committed
Use ProcessBuilder for mongocryptd output redirection
JAVA-3636
1 parent 896acb2 commit e12bde0

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

driver-core/src/main/com/mongodb/internal/capi/MongoCryptHelper.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.mongodb.crypt.capi.MongoLocalKmsProviderOptions;
2828
import org.bson.BsonDocument;
2929

30+
import java.io.File;
3031
import java.nio.ByteBuffer;
3132
import java.util.ArrayList;
3233
import java.util.List;
@@ -78,11 +79,6 @@ public static List<String> createMongocryptdSpawnArgs(final Map<String, Object>
7879
spawnArgs.add("--idleShutdownTimeoutSecs");
7980
spawnArgs.add("60");
8081
}
81-
if (!spawnArgs.contains("--logpath")) {
82-
spawnArgs.add("--logappend");
83-
spawnArgs.add("--logpath");
84-
spawnArgs.add(System.getProperty("os.name").startsWith("Windows") ? "NUL" : "/dev/null");
85-
}
8682
return spawnArgs;
8783
}
8884

@@ -113,7 +109,7 @@ public static ProcessBuilder createProcessBuilder(final Map<String, Object> opti
113109

114110
public static void startProcess(final ProcessBuilder processBuilder) {
115111
try {
116-
processBuilder.redirectOutput(ProcessBuilder.Redirect.DISCARD);
112+
processBuilder.redirectOutput(new File(System.getProperty("os.name").startsWith("Windows") ? "NUL" : "/dev/null"));
117113
processBuilder.start();
118114
} catch (Throwable t) {
119115
throw new MongoClientException("Exception starting mongocryptd process. Is `mongocryptd` on the system path?", t);

0 commit comments

Comments
 (0)