Skip to content

Commit 6f705ba

Browse files
committed
fix typo and tests
1 parent fad3686 commit 6f705ba

File tree

4 files changed

+20
-17
lines changed

4 files changed

+20
-17
lines changed

pymongo/asynchronous/uri_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
SCHEME_LEN,
3030
SRV_SCHEME_LEN,
3131
_check_options,
32-
_make_options_case_sensative,
32+
_make_options_case_sensitive,
3333
_validate_uri,
3434
split_hosts,
3535
split_options,
@@ -114,7 +114,7 @@ async def parse_uri(
114114
srv_max_hosts,
115115
)
116116
)
117-
result["options"] = _make_options_case_sensative(result["options"])
117+
result["options"] = _make_options_case_sensitive(result["options"])
118118
return result
119119

120120

pymongo/synchronous/uri_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
SCHEME_LEN,
3030
SRV_SCHEME_LEN,
3131
_check_options,
32-
_make_options_case_sensative,
32+
_make_options_case_sensitive,
3333
_validate_uri,
3434
split_hosts,
3535
split_options,
@@ -114,7 +114,7 @@ def parse_uri(
114114
srv_max_hosts,
115115
)
116116
)
117-
result["options"] = _make_options_case_sensative(result["options"])
117+
result["options"] = _make_options_case_sensitive(result["options"])
118118
return result
119119

120120

pymongo/uri_parser_shared.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,9 +603,12 @@ def _validate_uri(
603603
}
604604

605605

606-
def _make_options_case_sensative(options: _CaseInsensitiveDictionary) -> dict[str, Any]:
607-
case_sensative = {}
606+
def _make_options_case_sensitive(options: _CaseInsensitiveDictionary) -> dict[str, Any]:
607+
case_sensitive = {}
608608
for option in URI_OPTIONS:
609609
if option.lower() in options:
610-
case_sensative[option] = options[option]
611-
return case_sensative
610+
case_sensitive[option] = options[option]
611+
options.pop(option)
612+
for k, v in options.items():
613+
case_sensitive[k] = v
614+
return case_sensitive

test/test_uri_parser.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,8 @@ def test_parse_uri(self):
347347

348348
res = copy.deepcopy(orig)
349349
res["options"] = {
350-
"readpreference": ReadPreference.SECONDARY.mongos_mode,
351-
"readpreferencetags": [
350+
"readPreference": ReadPreference.SECONDARY.mongos_mode,
351+
"readPreferenceTags": [
352352
{"dc": "west", "use": "website"},
353353
{"dc": "east", "use": "website"},
354354
],
@@ -368,8 +368,8 @@ def test_parse_uri(self):
368368

369369
res = copy.deepcopy(orig)
370370
res["options"] = {
371-
"readpreference": ReadPreference.SECONDARY.mongos_mode,
372-
"readpreferencetags": [
371+
"readPreference": ReadPreference.SECONDARY.mongos_mode,
372+
"readPreferenceTags": [
373373
{"dc": "west", "use": "website"},
374374
{"dc": "east", "use": "website"},
375375
{},
@@ -457,10 +457,10 @@ def test_tlsinsecure_simple(self):
457457
self.maxDiff = None
458458
uri = "mongodb://example.com/?tlsInsecure=true"
459459
res = {
460-
"tlsallowinvalidhostnames": True,
461-
"tlsallowinvalidcertificates": True,
460+
"tlsAllowInvalidHostnames": True,
461+
"tlsAllowInvalidCertificates": True,
462462
"tlsInsecure": True,
463-
"tlsdisableocspendpointcheck": True,
463+
"tlsDisableOCSPEndpointCheck": True,
464464
}
465465
print(parse_uri(uri)["options"])
466466
self.assertEqual(res, parse_uri(uri)["options"])
@@ -492,8 +492,8 @@ def test_unquote_during_parsing(self):
492492
)
493493
res = parse_uri(uri)
494494
options = {
495-
"readpreference": ReadPreference.SECONDARY.mongos_mode,
496-
"readpreferencetags": [
495+
"readPreference": ReadPreference.SECONDARY.mongos_mode,
496+
"readPreferenceTags": [
497497
{"dc": "west", unquoted_val: unquoted_val},
498498
{"dc": "east", "use": unquoted_val},
499499
],

0 commit comments

Comments
 (0)