From 1a7a7f79b2e9daa7ecb40b0320bb48f11dc0857c Mon Sep 17 00:00:00 2001 From: Pavel Safronov Date: Mon, 29 Sep 2025 15:56:09 -0700 Subject: [PATCH 1/3] migrate --- test/integration/crud/promise_stats.test.js | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/test/integration/crud/promise_stats.test.js b/test/integration/crud/promise_stats.test.js index c41352a0253..14803d8848d 100644 --- a/test/integration/crud/promise_stats.test.js +++ b/test/integration/crud/promise_stats.test.js @@ -15,7 +15,7 @@ describe('stats', function () { } }, - test: function (done) { + test: async function () { var configuration = this.configuration; var url = configuration.url(); url = @@ -24,16 +24,10 @@ describe('stats', function () { : f('%s?%s', url, 'maxPoolSize=5'); const client = configuration.newClient(url); - client.connect().then(function (client) { - client - .db(configuration.db) - .stats() - .then(function (stats) { - test.ok(stats != null); - - client.close(done); - }); - }); + await client.connect(); + const stats = await client.db(configuration.db).stats(); + test.notEqual(null, stats); + await client.close(); } }); }); From 8297d3ad74ef9f207d2fa1650aa9f94b72fff392 Mon Sep 17 00:00:00 2001 From: bailey Date: Thu, 2 Oct 2025 10:43:54 -0600 Subject: [PATCH 2/3] ts refactor, renmae --- test/integration/crud/promise_stats.test.js | 33 --------------------- test/integration/crud/stats.test.ts | 11 +++++++ 2 files changed, 11 insertions(+), 33 deletions(-) delete mode 100644 test/integration/crud/promise_stats.test.js create mode 100644 test/integration/crud/stats.test.ts diff --git a/test/integration/crud/promise_stats.test.js b/test/integration/crud/promise_stats.test.js deleted file mode 100644 index 14803d8848d..00000000000 --- a/test/integration/crud/promise_stats.test.js +++ /dev/null @@ -1,33 +0,0 @@ -'use strict'; - -const { assert: test, setupDatabase } = require('../shared'); -const f = require('util').format; - -describe('stats', function () { - before(function () { - return setupDatabase(this.configuration); - }); - - it('Should correctly execute stats using Promise', { - metadata: { - requires: { - topology: ['single'] - } - }, - - test: async function () { - var configuration = this.configuration; - var url = configuration.url(); - url = - url.indexOf('?') !== -1 - ? f('%s&%s', url, 'maxPoolSize=5') - : f('%s?%s', url, 'maxPoolSize=5'); - - const client = configuration.newClient(url); - await client.connect(); - const stats = await client.db(configuration.db).stats(); - test.notEqual(null, stats); - await client.close(); - } - }); -}); diff --git a/test/integration/crud/stats.test.ts b/test/integration/crud/stats.test.ts new file mode 100644 index 00000000000..c91ecd61a1a --- /dev/null +++ b/test/integration/crud/stats.test.ts @@ -0,0 +1,11 @@ +import { expect } from 'chai'; + +describe('stats', function () { + it('correctly executes stats()', async function () { + const client = this.configuration.newClient(); + await client.connect(); + const stats = await client.db('foo').stats(); + expect(stats).not.to.be.null; + await client.close(); + }); +}); From 643acd4b72bbcd17a22cd80528e62c5e1747b749 Mon Sep 17 00:00:00 2001 From: bailey Date: Fri, 3 Oct 2025 13:07:33 -0600 Subject: [PATCH 3/3] refactor test to best practices --- test/integration/crud/stats.test.ts | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/test/integration/crud/stats.test.ts b/test/integration/crud/stats.test.ts index c91ecd61a1a..0a521c00e81 100644 --- a/test/integration/crud/stats.test.ts +++ b/test/integration/crud/stats.test.ts @@ -1,11 +1,21 @@ import { expect } from 'chai'; +import { type MongoClient } from '../../../src'; + describe('stats', function () { - it('correctly executes stats()', async function () { - const client = this.configuration.newClient(); + let client: MongoClient; + + beforeEach(async function () { + client = this.configuration.newClient(); await client.connect(); + }); + + afterEach(async function () { + await client.close(); + }); + + it('correctly executes stats()', async function () { const stats = await client.db('foo').stats(); expect(stats).not.to.be.null; - await client.close(); }); });