feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <cristina.sanchez@mongodb.com>

Author: csanx

.changelog/3451.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/mongodbatlas_projects: Adds `users` attribute
+```

docs/data-sources/project.md

@@ -124,5 +124,7 @@ In addition to all arguments above, the following attributes are exported:
 * `lastName`- Last name, family name, or surname that belongs to the MongoDB Cloud user.
 * `mobileNumber` - Mobile phone number that belongs to the MongoDB Cloud user.
 
+~> **NOTE:** - Does not return pending users invited via the deprecated [Invite One MongoDB Cloud User to Join One Project](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/operation/operation-createprojectinvitation) endpoint or pending invitations created using [`mongodbatlas_project_invitation`](../resources/project_invitation.md) resource.
+
 
 See [MongoDB Atlas API - Project](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Projects) - [and MongoDB Atlas API - Teams](https://docs.atlas.mongodb.com/reference/api/project-get-teams/) Documentation for more information.

docs/data-sources/projects.md

@@ -51,13 +51,14 @@ data "mongodbatlas_projects" "test" {
 
 * `name` - The name of the project you want to create.
 * `org_id` - The ID of the organization you want to create the project within.
+* `project_id`- Unique 24-hexadecimal digit string that identifies the MongoDB Cloud project.
 * `cluster_count` - The number of Atlas clusters deployed in the project.
 * `created` - The ISO-8601-formatted timestamp of when Atlas created the project.
 * `tags` - Map that contains key-value pairs between 1 to 255 characters in length for tagging and categorizing the project. To learn more, see [Resource Tags](https://www.mongodb.com/docs/atlas/tags/)
 * `teams` - Returns all teams to which the authenticated user has access in the project. See [Teams](#teams).
 * `limits` - The limits for the specified project. See [Limits](#limits).
 * `ip_addresses` - IP addresses in a project categorized by services. See [IP Addresses](#ip-addresses). **WARNING:** This attribute is deprecated, use the `mongodbatlas_project_ip_addresses` data source instead.
-
+* `users` - Returns list of all pending and active MongoDB Cloud users associated with the specified project.
 * `is_collect_database_specifics_statistics_enabled` - Flag that indicates whether to enable statistics in [cluster metrics](https://www.mongodb.com/docs/atlas/monitor-cluster-metrics/) collection for the project.
 * `is_data_explorer_enabled` - Flag that indicates whether to enable Data Explorer for the project. If enabled, you can query your database with an easy to use interface.
 * `is_extended_storage_sizes_enabled` - Flag that indicates whether to enable extended storage sizes for the specified project.
@@ -87,5 +88,18 @@ data "mongodbatlas_projects" "test" {
 * `services.clusters.#.inbound` - List of inbound IP addresses associated with the cluster. If your network allows outbound HTTP requests only to specific IP addresses, you must allow access to the following IP addresses so that your application can connect to your Atlas cluster.
 * `services.clusters.#.outbound` - List of outbound IP addresses associated with the cluster. If your network allows inbound HTTP requests only from specific IP addresses, you must allow access from the following IP addresses so that your Atlas cluster can communicate with your webhooks and KMS.
 
+### Users
+* `id`- Unique 24-hexadecimal digit string that identifies the MongoDB Cloud user.
+* `orgMembershipStatus`- String enum that indicates whether the MongoDB Cloud user has a pending invitation to join the organization or they are already active in the organization.
+* `roles`- One or more project-level roles assigned to the MongoDB Cloud user.
+* `username`- Email address that represents the username of the MongoDB Cloud user.
+* `country`- Two-character alphabetical string that identifies the MongoDB Cloud user's geographic location. This parameter uses the ISO 3166-1a2 code format.
+* `createdAt`- Date and time when MongoDB Cloud created the current account. This value is in the ISO 8601 timestamp format in UTC.
+* `firstName`- First or given name that belongs to the MongoDB Cloud user.
+* `lastAuth` - Date and time when the current account last authenticated. This value is in the ISO 8601 timestamp format in UTC.
+* `lastName`- Last name, family name, or surname that belongs to the MongoDB Cloud user.
+* `mobileNumber` - Mobile phone number that belongs to the MongoDB Cloud user.
+
+~> **NOTE:** - Does not return pending users invited via the deprecated [Invite One MongoDB Cloud User to Join One Project](https://www.mongodb.com/docs/api/doc/atlas-admin-api-v2/operation/operation-createprojectinvitation) endpoint or pending invitations created using [`mongodbatlas_project_invitation`](../resources/project_invitation.md) resource.
 
 See [MongoDB Atlas API - Projects](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Projects) - [and MongoDB Atlas API - Teams](https://docs.atlas.mongodb.com/reference/api/project-get-teams/) Documentation for more information.

internal/service/project/data_source_project.go

@@ -7,13 +7,7 @@ import (
 
 	"go.mongodb.org/atlas-sdk/v20250312004/admin"
 
-	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/datasource"
-	"github.com/hashicorp/terraform-plugin-framework/datasource/schema"
-	"github.com/hashicorp/terraform-plugin-framework/path"
-	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
-	"github.com/hashicorp/terraform-plugin-framework/types"
-	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/constant"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/dsschema"
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/config"
@@ -34,220 +28,10 @@ type projectDS struct {
 	config.DSCommon
 }
 
-type TFProjectDSModel struct {
-	Tags                                        types.Map              `tfsdk:"tags"`
-	IPAddresses                                 types.Object           `tfsdk:"ip_addresses"`
-	Created                                     types.String           `tfsdk:"created"`
-	OrgID                                       types.String           `tfsdk:"org_id"`
-	RegionUsageRestrictions                     types.String           `tfsdk:"region_usage_restrictions"`
-	ID                                          types.String           `tfsdk:"id"`
-	Name                                        types.String           `tfsdk:"name"`
-	ProjectID                                   types.String           `tfsdk:"project_id"`
-	Teams                                       []*TFTeamDSModel       `tfsdk:"teams"`
-	Limits                                      []*TFLimitModel        `tfsdk:"limits"`
-	Users                                       []*TFCloudUsersDSModel `tfsdk:"users"`
-	ClusterCount                                types.Int64            `tfsdk:"cluster_count"`
-	IsCollectDatabaseSpecificsStatisticsEnabled types.Bool             `tfsdk:"is_collect_database_specifics_statistics_enabled"`
-	IsRealtimePerformancePanelEnabled           types.Bool             `tfsdk:"is_realtime_performance_panel_enabled"`
-	IsSchemaAdvisorEnabled                      types.Bool             `tfsdk:"is_schema_advisor_enabled"`
-	IsPerformanceAdvisorEnabled                 types.Bool             `tfsdk:"is_performance_advisor_enabled"`
-	IsExtendedStorageSizesEnabled               types.Bool             `tfsdk:"is_extended_storage_sizes_enabled"`
-	IsDataExplorerEnabled                       types.Bool             `tfsdk:"is_data_explorer_enabled"`
-	IsSlowOperationThresholdingEnabled          types.Bool             `tfsdk:"is_slow_operation_thresholding_enabled"`
-}
-
-type TFTeamDSModel struct {
-	TeamID    types.String `tfsdk:"team_id"`
-	RoleNames types.List   `tfsdk:"role_names"`
-}
-
-type TFCloudUsersDSModel struct {
-	ID                  types.String `tfsdk:"id"`
-	OrgMembershipStatus types.String `tfsdk:"org_membership_status"`
-	Roles               types.List   `tfsdk:"roles"`
-	Username            types.String `tfsdk:"username"`
-	InvitationCreatedAt types.String `tfsdk:"invitation_created_at"`
-	InvitationExpiresAt types.String `tfsdk:"invitation_expires_at"`
-	InviterUsername     types.String `tfsdk:"inviter_username"`
-	Country             types.String `tfsdk:"country"`
-	CreatedAt           types.String `tfsdk:"created_at"`
-	FirstName           types.String `tfsdk:"first_name"`
-	LastAuth            types.String `tfsdk:"last_auth"`
-	LastName            types.String `tfsdk:"last_name"`
-	MobileNumber        types.String `tfsdk:"mobile_number"`
-}
-
 func (d *projectDS) Schema(ctx context.Context, req datasource.SchemaRequest, resp *datasource.SchemaResponse) {
-	resp.Schema = schema.Schema{
-		Attributes: map[string]schema.Attribute{
-			"id": schema.StringAttribute{
-				Computed: true,
-			},
-			"project_id": schema.StringAttribute{
-				Optional: true,
-				Validators: []validator.String{
-					stringvalidator.ConflictsWith(path.MatchRoot("name")),
-				},
-			},
-			"name": schema.StringAttribute{
-				Optional: true,
-				Validators: []validator.String{
-					stringvalidator.ConflictsWith(path.MatchRoot("project_id")),
-				},
-			},
-			"org_id": schema.StringAttribute{
-				Computed: true,
-			},
-			"cluster_count": schema.Int64Attribute{
-				Computed: true,
-			},
-			"created": schema.StringAttribute{
-				Computed: true,
-			},
-			"is_collect_database_specifics_statistics_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_data_explorer_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_extended_storage_sizes_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_performance_advisor_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_realtime_performance_panel_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_schema_advisor_enabled": schema.BoolAttribute{
-				Computed: true,
-			},
-			"is_slow_operation_thresholding_enabled": schema.BoolAttribute{
-				DeprecationMessage: constant.DeprecationParam, // added deprecation in CLOUDP-293855 because was deprecated in the doc
-				Computed:           true,
-			},
-			"region_usage_restrictions": schema.StringAttribute{
-				Computed: true,
-			},
-			"teams": schema.ListNestedAttribute{
-				Computed: true,
-				NestedObject: schema.NestedAttributeObject{
-					Attributes: map[string]schema.Attribute{
-						"team_id": schema.StringAttribute{
-							Computed: true,
-						},
-						"role_names": schema.ListAttribute{
-							Computed:    true,
-							ElementType: types.StringType,
-						},
-					},
-				},
-			},
-			"limits": schema.SetNestedAttribute{
-				Computed: true,
-				NestedObject: schema.NestedAttributeObject{
-					Attributes: map[string]schema.Attribute{
-						"name": schema.StringAttribute{
-							Computed: true,
-						},
-						"value": schema.Int64Attribute{
-							Computed: true,
-						},
-						"current_usage": schema.Int64Attribute{
-							Computed: true,
-						},
-						"default_limit": schema.Int64Attribute{
-							Computed: true,
-						},
-						"maximum_limit": schema.Int64Attribute{
-							Computed: true,
-						},
-					},
-				},
-			},
-			"ip_addresses": schema.SingleNestedAttribute{
-				Computed:           true,
-				DeprecationMessage: fmt.Sprintf(constant.DeprecationParamWithReplacement, "mongodbatlas_project_ip_addresses data source"),
-				Attributes: map[string]schema.Attribute{
-					"services": schema.SingleNestedAttribute{
-						Computed: true,
-						Attributes: map[string]schema.Attribute{
-							"clusters": schema.ListNestedAttribute{
-								Computed: true,
-								NestedObject: schema.NestedAttributeObject{
-									Attributes: map[string]schema.Attribute{
-										"cluster_name": schema.StringAttribute{
-											Computed: true,
-										},
-										"inbound": schema.ListAttribute{
-											ElementType: types.StringType,
-											Computed:    true,
-										},
-										"outbound": schema.ListAttribute{
-											ElementType: types.StringType,
-											Computed:    true,
-										},
-									},
-								},
-							},
-						},
-					},
-				},
-			},
-			"tags": schema.MapAttribute{
-				ElementType: types.StringType,
-				Computed:    true,
-			},
-			"users": schema.SetNestedAttribute{
-				Computed: true,
-				NestedObject: schema.NestedAttributeObject{
-					Attributes: map[string]schema.Attribute{
-						"id": schema.StringAttribute{
-							Computed: true,
-						},
-						"org_membership_status": schema.StringAttribute{
-							Computed: true,
-						},
-						"roles": schema.ListAttribute{
-							Computed:    true,
-							ElementType: types.StringType,
-						},
-						"username": schema.StringAttribute{
-							Computed: true,
-						},
-						"invitation_created_at": schema.StringAttribute{
-							Computed: true,
-						},
-						"invitation_expires_at": schema.StringAttribute{
-							Computed: true,
-						},
-						"inviter_username": schema.StringAttribute{
-							Computed: true,
-						},
-						"country": schema.StringAttribute{
-							Computed: true,
-						},
-						"created_at": schema.StringAttribute{
-							Computed: true,
-						},
-						"first_name": schema.StringAttribute{
-							Computed: true,
-						},
-						"last_auth": schema.StringAttribute{
-							Computed: true,
-						},
-						"last_name": schema.StringAttribute{
-							Computed: true,
-						},
-						"mobile_number": schema.StringAttribute{
-							Computed: true,
-						},
-					},
-				},
-			},
-		},
-	}
-	conversion.UpdateSchemaDescription(&resp.Schema)
+	resp.Schema = conversion.DataSourceSchemaFromResource(ResourceSchema(ctx), &conversion.DataSourceSchemaRequest{
+		OverridenFields: dataSourceOverridenFields(),
+	})
 }
 
 func (d *projectDS) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {