Skip to content

Commit 1f352be

Browse files
authored
Disable 'Hide downstream / reassigned to / invalid' when selected sta… (#8356)
* Disable 'Hide downstream / reassigned to / invalid' when selected status is downstream/reassigned/invalid * run yarn lint * Fix change status filter function * add logic for all statuses
1 parent 9490ea9 commit 1f352be

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

ui/perfherder/alerts/AlertsViewControls.jsx

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ export default class AlertsViewControls extends React.Component {
1616
.fill(null)
1717
.map(() => React.createRef());
1818
this.state = {
19+
disableHideDownstream: ['invalid', 'reassigned', 'downstream'].includes(
20+
props.filters.status,
21+
),
1922
currentAlert: -1,
2023
alertsLength: this.props.alertSummaries.length,
2124
disableButtons: {
@@ -58,7 +61,19 @@ export default class AlertsViewControls extends React.Component {
5861

5962
updateStatus = (status) => {
6063
const { setFiltersState, updateViewState } = this.props;
61-
setFiltersState({ status });
64+
65+
const isInvalidStatus = [
66+
'invalid',
67+
'reassigned',
68+
'downstream',
69+
'all statuses',
70+
].includes(status);
71+
72+
this.setState({
73+
disableHideDownstream:
74+
status === 'all statuses' ? false : isInvalidStatus,
75+
});
76+
setFiltersState({ status, hideDownstream: !isInvalidStatus });
6277
updateViewState({ page: 1 });
6378
};
6479

@@ -160,6 +175,7 @@ export default class AlertsViewControls extends React.Component {
160175
text: 'Hide downstream / reassigned to / invalid',
161176
state: hideDownstream,
162177
stateName: 'hideDownstream',
178+
disable: this.state.disableHideDownstream,
163179
},
164180
];
165181

@@ -168,6 +184,7 @@ export default class AlertsViewControls extends React.Component {
168184
text: 'My alerts',
169185
state: hideAssignedToOthers,
170186
stateName: 'hideAssignedToOthers',
187+
disable: false,
171188
});
172189
}
173190

ui/shared/FilterControls.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ const FilterControls = ({
5858
outline
5959
onClick={() => updateFilter(filter.stateName)}
6060
active={filter.state}
61+
disabled={filter.disable}
6162
>
6263
{filter.text}
6364
</Button>

0 commit comments

Comments
 (0)