fix: Fix false positive for expect-expect when using test.step

Fixes #149

Author: mskelton

src/rules/expect-expect.ts

@@ -20,7 +20,7 @@ export default {
 
     return {
       CallExpression(node) {
-        if (isTest(node)) {
+        if (isTest(node, ['fixme', 'only', 'skip'])) {
           unchecked.push(node);
         } else if (isExpectCall(node)) {
           checkExpressions(context.getAncestors());

src/utils/ast.ts

@@ -94,10 +94,13 @@ export function findParent<T extends ESTree.Node['type']>(
     : findParent(node.parent, type);
 }
 
-export function isTest(node: ESTree.CallExpression) {
+export function isTest(node: ESTree.CallExpression, modifiers?: string[]) {
   return (
     isTestIdentifier(node.callee) &&
     !isDescribeCall(node) &&
+    (node.callee.type !== 'MemberExpression' ||
+      !modifiers ||
+      modifiers?.includes(getStringValue(node.callee.property))) &&
     node.arguments.length === 2 &&
     ['ArrowFunctionExpression', 'FunctionExpression'].includes(
       node.arguments[1].type

test/spec/expect-expect.spec.ts

@@ -1,3 +1,4 @@
+import dedent = require('dedent');
 import rule from '../../src/rules/expect-expect';
 import { runRuleTester } from '../utils/rule-tester';
 
@@ -17,5 +18,23 @@ runRuleTester('expect-expect', rule, {
     '["bar"]();',
     'testing("will test something eventually", () => {})',
     'test("should pass", () => expect(true).toBeDefined())',
+    {
+      code: dedent`
+        test('steps', async ({ page }) => {
+          await test.step('first tab', async () => {
+            await expect(page.getByText('Hello')).toBeVisible();
+          });
+        });
+      `,
+    },
+    {
+      code: dedent`
+        test.only('steps', async ({ page }) => {
+          await test.step('first tab', async () => {
+            await expect(page.getByText('Hello')).toBeVisible();
+          });
+        });
+      `,
+    },
   ],
 });