From bef0f00c0a428c552935b002c865f4ec3c59db93 Mon Sep 17 00:00:00 2001 From: threader Date: Sun, 6 Feb 2022 04:48:15 +0100 Subject: [PATCH 1/3] headers: comments compliance with kernel code Signed-off-by: --- driver.py | 10 ++++++---- lk.py | 11 ++++++----- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/driver.py b/driver.py index 3e2a1bd..e610dbf 100644 --- a/driver.py +++ b/driver.py @@ -468,10 +468,12 @@ def generate_driver(p: Panel, options: Options) -> None: module = f"panel-{dash_id}" with open(f'{p.id}/{module}.c', 'w') as f: f.write(f'''\ -// SPDX-License-Identifier: GPL-2.0-only -// Copyright (c) {datetime.date.today().year} FIXME -// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: -// Copyright (c) 2013, The Linux Foundation. All rights reserved. (FIXME) +/* + * SPDX-License-Identifier: GPL-2.0-only + * Copyright (c) {datetime.date.today().year} FIXME + * Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: + * Copyright (c) 2013, The Linux Foundation. All rights reserved. (FIXME) + */ {generate_includes(p, options)} {generate_struct(p, options)} diff --git a/lk.py b/lk.py index cea93a4..e7700d0 100644 --- a/lk.py +++ b/lk.py @@ -110,11 +110,12 @@ def generate_lk_driver(p: Panel) -> None: with open(f'{p.id}/lk_panel_{p.id}.h', 'w') as f: f.write(f'''\ -// SPDX-License-Identifier: GPL-2.0-only -// Copyright (c) {datetime.date.today().year} FIXME -// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: -// Copyright (c) 2014, The Linux Foundation. All rights reserved. (FIXME) - +/* + * SPDX-License-Identifier: GPL-2.0-only + * Copyright (c) {datetime.date.today().year} FIXME + * Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: + * Copyright (c) 2014, The Linux Foundation. All rights reserved. (FIXME) + */ #ifndef {define} #define {define} From 673e435cd3e714bf4ee80572c209385e6e4fb769 Mon Sep 17 00:00:00 2001 From: threader Date: Sun, 6 Feb 2022 22:28:11 +0100 Subject: [PATCH 2/3] README: The mentioned example driver s6e88a0-ams452ef01 is mainlined, but the original generated example i cant find??? Signed-off-by: --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 411ceea..09bd5bc 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,8 @@ changes are necessary for upstreaming the generated panel driver. - Generated panel driver: [`panel-s6e88a0-ams452ef01.c`](https://gist.github.com/Minecrell/bc5fbfc3ba98873d32c07793d6997172#file-panel-s6e88a0-ams452ef01-c), [`panel-simple-s6e88a0-ams452ef01.c`](https://gist.github.com/Minecrell/bc5fbfc3ba98873d32c07793d6997172#file-panel-simple-s6e88a0-ams452ef01-c) + - Mainlined panel driver: + [`panel-samsung-s6e88a0-ams452ef01.c`](https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c) ## Preparation ### Requirements From bbf7a63df8e0065b4c4474f0a16b3fea7c6b2cb8 Mon Sep 17 00:00:00 2001 From: threader Date: Mon, 7 Feb 2022 21:54:17 +0100 Subject: [PATCH 3/3] README: Add panel-auo-novatek-1080p example by Rob Clark --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 09bd5bc..1c25bc3 100644 --- a/README.md +++ b/README.md @@ -12,10 +12,14 @@ changes are necessary for upstreaming the generated panel driver. - Input device tree: [`dsi_panel_S6E88A0_AMS452EF01_qhd_octa_video.dtsi`](https://gist.github.com/Minecrell/56c2b20118ba00a9723f0785301bc5ec#file-dsi_panel_s6e88a0_ams452ef01_qhd_octa_video-dtsi) - Generated panel driver: - [`panel-s6e88a0-ams452ef01.c`](https://gist.github.com/Minecrell/bc5fbfc3ba98873d32c07793d6997172#file-panel-s6e88a0-ams452ef01-c), + [`panel-s6e88a0-ams452ef01.c`](https://gist.github.com/Minecrell/bc5fbfc3ba98873d32c07793d6997172#file-panel-s6e88a0-ams452ef01-c) [`panel-simple-s6e88a0-ams452ef01.c`](https://gist.github.com/Minecrell/bc5fbfc3ba98873d32c07793d6997172#file-panel-simple-s6e88a0-ams452ef01-c) + - Precurser to this generator was the work of Rob Clark on the Sony Z3 msm8974 panel drivers with Freedreno: + [`panel-auo-novatek-1080p-vid.c`](https://github.com/freedreno/kernel-msm/blob/xperiadev/drivers/gpu/drm/panel/panel-auo-novatek-1080p-vid.c) - Mainlined panel driver: [`panel-samsung-s6e88a0-ams452ef01.c`](https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams452ef01.c) + - Example for msm8974 on how to set up dtsi: + [`Sony Z3`](https://github.com/freedreno/kernel-msm/commits/xperiadev/arch/arm/boot/dts) ## Preparation ### Requirements