Compiling with MACROS="-DMC_WINDOW_ID_TYPE=uint16_t"

[Gullumluvl]

Hi again,

I am trying different compilation options, and this one does not seem to work. I get:

make release_dummy DIR=build_release ARTIFACT=metacache MACROS="-DMC_WINDOW_ID_TYPE=uint16_t"
make[1]: Entering directory '/home/guillaume/install/metacache'
mkdir build_release
g++  -DMC_WINDOW_ID_TYPE=uint16_t -std=c++14 -Wall -Wextra -Wpedantic -I/include -O3 -c src/building.cpp -o build_release/building.o
In file included from src/options.h:31,
                 from src/candidate_structs.h:28,
                 from src/candidate_generation.h:27,
                 from src/database.h:27,
                 from src/building.h:27,
                 from src/building.cpp:24:
src/taxonomy.h: In member function ‘std::pair<const mc::taxonomy::taxon*, bool> mc::taxonomy_cache::emplace_target_taxon(taxon_id, taxon_id, taxon_name, const file_source&)’:
src/taxonomy.h:1149:56: warning: redundant move in initialization [-Wredundant-move]
 1149 |                                               std::move(source));
      |                                               ~~~~~~~~~^~~~~~~~
src/taxonomy.h:1149:56: note: remove ‘std::move’ call
In file included from src/classification.h:29,
                 from src/printing.h:27,
                 from src/building.cpp:33:
src/database_query.h: In lambda function:
src/database_query.h:234:24: error: no matching function for call to ‘max(mc::window_id, int)’
  234 |         return std::max(window_id(1), numWindows1 + numWindows2);
      |                ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/14/string:51,
                 from src/bitmanip.h:29,
                 from src/dna_encoding.h:27,
                 from src/hash_dna.h:27,
                 from src/config.h:34,
                 from src/candidate_structs.h:27:
/usr/include/c++/14/bits/stl_algobase.h:257:5: note: candidate: ‘template<class _Tp> constexpr const _Tp& std::max(const _Tp&, const _Tp&)’
  257 |     max(const _Tp& __a, const _Tp& __b)
      |     ^~~
/usr/include/c++/14/bits/stl_algobase.h:257:5: note:   template argument deduction/substitution failed:
src/database_query.h:234:24: note:   deduced conflicting types for parameter ‘const _Tp’ (‘short unsigned int’ and ‘int’)
  234 |         return std::max(window_id(1), numWindows1 + numWindows2);
      |                ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/14/bits/stl_algobase.h:303:5: note: candidate: ‘template<class _Tp, class _Compare> constexpr const _Tp& std::max(const _Tp&, const _Tp&, _Compare)’
  303 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
/usr/include/c++/14/bits/stl_algobase.h:303:5: note:   candidate expects 3 arguments, 2 provided
In file included from /usr/include/c++/14/algorithm:61,
                 from src/../dep/hpc_helpers/include/cuda_helpers.cuh:7,
                 from src/dna_encoding.h:30:
/usr/include/c++/14/bits/stl_algo.h:5706:5: note: candidate: ‘template<class _Tp> constexpr _Tp std::max(initializer_list<_Tp>)’
 5706 |     max(initializer_list<_Tp> __l)
      |     ^~~
/usr/include/c++/14/bits/stl_algo.h:5706:5: note:   candidate expects 1 argument, 2 provided
/usr/include/c++/14/bits/stl_algo.h:5716:5: note: candidate: ‘template<class _Tp, class _Compare> constexpr _Tp std::max(initializer_list<_Tp>, _Compare)’
 5716 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
/usr/include/c++/14/bits/stl_algo.h:5716:5: note:   template argument deduction/substitution failed:
src/database_query.h:234:24: note:   mismatched types ‘std::initializer_list<_Tp>’ and ‘short unsigned int’
  234 |         return std::max(window_id(1), numWindows1 + numWindows2);
      |                ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:215: build_release/building.o] Error 1
make[1]: Leaving directory '/home/guillaume/install/metacache'
make: *** [Makefile:137: release] Error 2

Maybe related to #36 ?

I am on Debian Trixie, using g++ (Debian 14.2.0-17) 14.2.0

Best,