PHP 8.0 compatibility issues

[yuliu]

This issue will track the merge system's PHP 8.0 compatibility problem. Any PR fixing any of them is welcome.

[yuliu]

Warning: Declaration of debugErrorHandler::error($type, $message, $file = NULL, $line = 0) should be compatible with errorHandler::error($type, $message, $file = NULL, $line = 0, $allow_output = true) in /merge/resources/class_error.php on line 34

Already reported in #273, other reports from the community forum:
https://community.mybb.com/thread-234192-post-1372839.html#pid1372839

[yuliu]

create_function() was removed in 8.0 PHP version.

merge-system/resources/functions.php

Lines 728 to 739 in 755ae59

	function utf8_unhtmlentities($string)
	{
	// Replace numeric entities
	$string = preg_replace_callback('~&#x([0-9a-f]+);~i', create_function('$matches', 'return unichr(hexdec($matches[1]));'), $string);
	$string = preg_replace_callback('~&#([0-9]+);~', create_function('$matches', 'return unichr($matches[1]);'), $string);
	// Replace literal entities
	$trans_tbl = get_html_translation_table(HTML_ENTITIES);
	$trans_tbl = array_flip($trans_tbl);
	return strtr($string, $trans_tbl);
	}

merge-system/boards/vbulletin3/privatemessages.php

Line 64 in 755ae59

array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);'));

merge-system/boards/vbulletin4/privatemessages.php

Line 64 in 755ae59

array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);'));

merge-system/boards/vbulletin5/privatemessages.php

Line 64 in 755ae59

array_walk_recursive($touserarray, create_function('&$value, $key', '$value = utf8_encode($value);'));

[yuliu]

From #279 bbpress's delcaration get_group_id() isn't compatible with parent class's

BBPRESS_Converter->get_group_id():

merge-system/boards/bbpress.php

Line 100 in d453ec2

function get_group_id($gids)

Converter->get_group_id():

merge-system/resources/class_converter.php

Line 531 in d453ec2

function get_group_id($gids, $remove=array())

[DMiurge]

anyone going to tackle the PHP8 incompability? PHP8 has been around for some time now. Why isn't the merge system still not working?