@@ -65,26 +65,15 @@ def test_is_finite_series(constructor_eager: ConstructorEager) -> None:
6565 assert_equal_data (result , expected )
6666
6767
68- def test_is_finite_integer_column (
69- constructor : Constructor , request : pytest .FixtureRequest
70- ) -> None :
71- if "sqlframe" in str (constructor ):
72- # https://github.com/eakmanrq/sqlframe/issues/542
73- request .applymarker (pytest .mark .xfail )
74-
68+ def test_is_finite_integer_column (constructor : Constructor ) -> None :
7569 # Test for https://github.com/narwhals-dev/narwhals/issues/3255
7670 df = nw .from_native (constructor ({"a" : [1 , 2 , 3 ]}))
7771 result = df .select (nw .col ("a" ).is_finite ())
7872 assert_equal_data (result , {"a" : [True , True , True ]})
7973
8074
8175@pytest .mark .parametrize ("data" , [[1 , 2 , None ], [1.0 , 2.0 , None ]])
82- def test_is_finite_column_with_null (
83- constructor : Constructor , request : pytest .FixtureRequest , data : list [float ]
84- ) -> None :
85- if "sqlframe" in str (constructor ) and isinstance (data [0 ], int ):
86- # https://github.com/eakmanrq/sqlframe/issues/542
87- request .applymarker (pytest .mark .xfail )
76+ def test_is_finite_column_with_null (constructor : Constructor , data : list [float ]) -> None :
8877 if "polars" in str (constructor ) and POLARS_VERSION < (1 , 0 , 0 ):
8978 pytest .skip ("need newer polars version" )
9079 df = nw .from_native (constructor ({"a" : data }))
0 commit comments