Skip to content

Commit 13b6396

Browse files
committed
Address comments from PR #19:
* Style fix in aws.py * Move code inside try block in main.py
1 parent 1ba085d commit 13b6396

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

nd_okta_auth/aws.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ def assume_role(self):
180180
try:
181181
if len(self.assertion.roles()) > 1:
182182
raise MultipleRoles
183-
else:
184-
self.role = self.assertion.roles()[0]
183+
self.role = self.assertion.roles()[0]
185184
except xml.etree.ElementTree.ParseError:
186185
log.error('Could not find any Role in the SAML assertion')
187186
log.error(self.assertion.__dict__)

nd_okta_auth/main.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,13 @@ def main(argv):
170170
time.sleep(15)
171171
continue
172172

173-
# Only set up the session if it's still None
174-
if session is None:
175-
assertion = okta_client.get_assertion(appid=config.appid,
176-
apptype='amazon_aws')
177-
session = aws.Session(assertion, profile=config.name)
178-
179173
try:
174+
# Only set up the session if it's still None
175+
if session is None:
176+
assertion = okta_client.get_assertion(appid=config.appid,
177+
apptype='amazon_aws')
178+
session = aws.Session(assertion, profile=config.name)
179+
180180
log.info('Getting SAML Assertion from {org}'.format(
181181
org=config.org))
182182
session.assume_role()

0 commit comments

Comments
 (0)