Skip to content

fix: editing a hidden event shouldn't fail #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: editing a hidden event shouldn't fail #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apollo/frontend/views_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# -*- coding: utf-8 -*-
import re
from datetime import datetime
from io import BytesIO
from urllib.parse import urlencode
Expand Down Expand Up @@ -209,12 +210,15 @@ def get_query(self):
def filter_hidden(self, query):
model_class = self.model
query_params = request.args.to_dict(flat=False)
show_hidden = bool(query_params.get(self.query_param_name))
if show_hidden:
show_hidden_direct = bool(query_params.get(self.query_param_name))
show_hidden_param = any(
re.search(rf'{self.query_param_name}=[^&]+', item)
for item in query_params.get("url", [])
)
if show_hidden_direct or show_hidden_param:
pass
else:
query = query.filter(model_class.is_hidden == False) # noqa

return query

def render(self, template, **kwargs):
Expand Down