|
| 1 | +`8.0.15 (2023-12-06) <https://github.com/neos/flow-development-collection/releases/tag/8.0.15>`_ |
| 2 | +================================================================================================ |
| 3 | + |
| 4 | +Overview of merged pull requests |
| 5 | +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| 6 | + |
| 7 | +`Revert "BUGFIX: Sanitize uploaded svg files for suspicious contents" <https://github.com/neos/flow-development-collection/pull/3249>`_ |
| 8 | +--------------------------------------------------------------------------------------------------------------------------------------- |
| 9 | + |
| 10 | +As discussed in team meeting, this reverts commit `a1642ef31f19a974f34a302c98c13c77b6422ba1 <https://github.com/neos/flow-development-collection/commit/a1642ef31f19a974f34a302c98c13c77b6422ba1>`_ |
| 11 | +as it raises issues when workong with streams (https://github.com/neos/flow-development-collection/issues/3246). |
| 12 | + |
| 13 | +Original PR: https://github.com/neos/flow-development-collection/pull/3172 |
| 14 | + |
| 15 | +See also: https://github.com/neos/flow-development-collection/issues/3248 |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | +* Packages: ``Flow`` ``Utility.MediaTypes`` |
| 20 | + |
| 21 | +`BUGFIX: Assume content exists, if stream size is unknown <https://github.com/neos/flow-development-collection/pull/3250>`_ |
| 22 | +--------------------------------------------------------------------------------------------------------------------------- |
| 23 | + |
| 24 | +If a PSR7 stream is returned from an ``ActionController`` action, no content arrives at the client, if the stream has an unknown size. |
| 25 | + |
| 26 | +Why is that? Because the check in our ``ActionResponse`` in ``hasContent()`` is implemented like this: |
| 27 | + |
| 28 | + $this->content->getSize() > 0 |
| 29 | + |
| 30 | +If a stream returns ``null`` here, because the size is unknown, we should assume content exists... |
| 31 | + |
| 32 | +There should be no change in behavior, even if the stream is in fact empty. Because that would lead to ``hasContent()`` returning ``true``, and the HTTP response being built in ``ActionResponse`` would get the stream as content. When being delivered that would evaluate to "a stream from an empty string", so there will be (again) no difference, if you look at what the ``MessageTrait``does if the internal stream is ``null``: |
| 33 | + |
| 34 | +```php |
| 35 | + public function getBody(): StreamInterface |
| 36 | + { |
| 37 | + if (!$this->stream) { |
| 38 | + $this->stream = Utils::streamFor(''); |
| 39 | + } |
| 40 | +
|
| 41 | + return $this->stream; |
| 42 | + } |
| 43 | +``` |
| 44 | + |
| 45 | +**Upgrade instructions** |
| 46 | + |
| 47 | + |
| 48 | +* Packages: ``Flow`` |
| 49 | + |
| 50 | +`BUGFIX: Update requirements.txt <https://github.com/neos/flow-development-collection/pull/3242>`_ |
| 51 | +-------------------------------------------------------------------------------------------------- |
| 52 | + |
| 53 | +Update requirements to build documentation based on security suggestions. |
| 54 | + |
| 55 | +* Packages: ``Flow`` |
| 56 | + |
| 57 | +`TASK: Add PHP 8.3 to build workflow matrix <https://github.com/neos/flow-development-collection/pull/3243>`_ |
| 58 | +------------------------------------------------------------------------------------------------------------- |
| 59 | + |
| 60 | +This will test Flow against PHP 8.3 |
| 61 | + |
| 62 | + |
| 63 | +* Packages: ``Eel`` ``Flow`` ``FluidAdaptor`` ``Kickstarter`` |
| 64 | + |
| 65 | +`Detailed log <https://github.com/neos/flow-development-collection/compare/8.0.14...8.0.15>`_ |
| 66 | +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
0 commit comments