|
| 1 | +`8.3.9 (2024-05-24) <https://github.com/neos/flow-development-collection/releases/tag/8.3.9>`_ |
| 2 | +============================================================================================== |
| 3 | + |
| 4 | +Overview of merged pull requests |
| 5 | +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| 6 | + |
| 7 | +`BUGFIX: Fix count for query across OneToMany joins <https://github.com/neos/flow-development-collection/pull/3345>`_ |
| 8 | +--------------------------------------------------------------------------------------------------------------------- |
| 9 | + |
| 10 | +The ``Query->count`` now returns the correct count when a criterion is added on a OneToMany relation. |
| 11 | + |
| 12 | +**Review instructions** |
| 13 | + |
| 14 | +The problem is described in details in #3331. Same as PR #3342, but this time against the correct branch. |
| 15 | + |
| 16 | +- [ ] Reviewer - Breaking Changes are marked with ``!!!`` and have upgrade-instructions |
| 17 | + |
| 18 | +* Packages: ``Flow`` |
| 19 | + |
| 20 | +`BUGFIX: Pass composer event to update and install scripts <https://github.com/neos/flow-development-collection/pull/3348>`_ |
| 21 | +---------------------------------------------------------------------------------------------------------------------------- |
| 22 | + |
| 23 | +Currently it is not possible to get the composer event in install and update scripts. With this fix it is possible if the script should be interactive, for example: ``$event->getIO()->isInteractive()`` |
| 24 | + |
| 25 | +* Packages: ``Flow`` |
| 26 | + |
| 27 | +`BUGFIX: Discover autoloader from FLOW_ROOTPATH rather than __DIR__ <https://github.com/neos/flow-development-collection/pull/3343>`_ |
| 28 | +------------------------------------------------------------------------------------------------------------------------------------- |
| 29 | + |
| 30 | +**The Problem** |
| 31 | + |
| 32 | +In my development setups (for contribution), I prefer to have every repo that is under development installed via composer ``path`` repositories, like so: |
| 33 | + |
| 34 | +```json |
| 35 | +{ |
| 36 | + "name": "vendor/dev-distribution", |
| 37 | + "require": { |
| 38 | + "neos/flow-development-collection": "9.0.x-dev", |
| 39 | + "neos/neos-development-collection": "9.0.x-dev", |
| 40 | + "neos/neos-ui": "9.0.x-dev", |
| 41 | + "vendor/site": "^1.0" |
| 42 | + }, |
| 43 | + "repositories": { |
| 44 | + "local": { |
| 45 | + "type": "path", |
| 46 | + "url": "./DistributionPackages/*" |
| 47 | + }, |
| 48 | + "dev": { |
| 49 | + "type": "path", |
| 50 | + "url": "./DevelopmentPackages/*" |
| 51 | + } |
| 52 | + } |
| 53 | +} |
| 54 | +``` |
| 55 | + |
| 56 | +Now if I clone, say, ``neos/neos-development-collection`` into ``DevelopmentPackages/``, composer will install the local version rather than the one from packagist. |
| 57 | + |
| 58 | +This works for ``neos/neos-development-collection``, ``neos/neos-ui`` and pretty much any other package around, but not for ``neos/flow-development-collection``. |
| 59 | + |
| 60 | +The ``flow`` CLI script makes the assumption that it is always located under ``Packages/*/`` and uses this assumption to discover the ``autoload.php`` script. It does so starting at its own path using the ``__DIR__`` constant. |
| 61 | + |
| 62 | +Unfortunately, PHP resolves symlinks before it sets the ``__DIR__`` constant. So when flow is installed via symlink, ``__DIR__`` does not contain its symlinked location, but its *real* location. This way it guesses the wrong path for ``autoload.php``, rendering the ``flow`` CLI script unusable. |
| 63 | + |
| 64 | +**The solution** |
| 65 | + |
| 66 | +The ``flow`` CLI script also figures out the ``FLOW_ROOTPATH``. It does so just after the autoload discovery. |
| 67 | + |
| 68 | +I guessed that it would be a safe assumption that the ``autoload.php`` can always be found under ``FLOW_ROOTPATH/Packages/Libraries/autoload.php``. *(though actually, this path may have been configured differently, but flow wouldn't be able to handle that as of right now)* |
| 69 | + |
| 70 | +Therefore, I moved the composer autload discovery below the ``FLOW_ROOTPATH`` discovery, to then use ``FLOW_ROOTPATH`` as a starting point. |
| 71 | + |
| 72 | +I'm pretty sure this is applicable to lower branches as well, but I didn't test this yet, so I'm targeting ``9.0`` for now. |
| 73 | + |
| 74 | +* Packages: ``Flow`` |
| 75 | + |
| 76 | +`Detailed log <https://github.com/neos/flow-development-collection/compare/8.3.8...8.3.9>`_ |
| 77 | +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
0 commit comments