fix default crowmail values #975
Conversation
|
Hi @tollsimy. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
|
/rebase |
|
/rebase |
1 similar comment
|
/rebase |
|
@frisso, bot commands aren't working because the PR wasn't created with the flag to let maintainers make changes to the branch |
This explains why the "rebase" didn't have any effect, and I didn't know the reason :-( |
@frisso It seems like I can't enable that setting because the PR was not opened by me.
In either case, I can take care of rebasing the branch onto master. |
|
For me, both options are valid. |
tollsimy
force-pushed
the
crownmails-config
branch
from
c7817f8 to
5dfa95e
Compare
|
@frisso @andreabuon |
|
I can work on this PR and delete the new one |
| currentInstance := &crownlabsv1alpha2.Instance{} | ||
| instanceLookupKey := types.NamespacedName{Name: PersistentInstanceName2, Namespace: tenant.Namespace} | ||
| Expect(k8sClient.Get(ctx, instanceLookupKey, currentInstance)).Should(Succeed()) | ||
| //Expect(k8sClient.Get(ctx, instanceLookupKey, currentInstance)).Should(Succeed()) |
There was a problem hiding this comment.
| //Expect(k8sClient.Get(ctx, instanceLookupKey, currentInstance)).Should(Succeed()) | |
| // Expect(k8sClient.Get(ctx, instanceLookupKey, currentInstance)).Should(Succeed()) |
| CustomDeleteAfterNonPersistent = instautoctrl.NeverTimeoutValue | ||
| CustomInactivityTimeoutNonPersistent = "1m" | ||
| CustomInactivityTimeoutNonPersistent = "0m" | ||
| CustomDeleteAfterPersistent2 = instautoctrl.NeverTimeoutValue |
There was a problem hiding this comment.
What's the meaning of the number "2" in the name of the variable?
| } | ||
|
|
||
| tracer.Step("expiration checked") | ||
| log.Info("Evaluate remaining time untill expiration", remainingTime, instance.Name) |
There was a problem hiding this comment.
| log.Info("Evaluate remaining time untill expiration", remainingTime, instance.Name) | |
| log.Info("Evaluate remaining time until expiration", remainingTime, instance.Name) |
|
I don't have the rights to modify the PR, hence I cannot make my commits directly; please accept my comments, as they are related to linting errors. |
6 participants
Description
Fix default CrownMails configs.