chore: review fixes

Author: danez

packages/config-schema/src/schema/netlify-toml.schema.json

@@ -610,6 +610,11 @@
           "type": "number",
           "default": 8888
         },
+        "staticServerPort": {
+          "title": "Static server port",
+          "description": "Port for the static file server. This value will only take effect if `framework` is set to `#static` or `#auto` without any framework being detected.",
+          "type": "number"
+        },
         "targetPort": {
           "title": "Target port",
           "description": "Port for your application server, framework, or site generator. If provided, the CLI will wait until the provided `targetPort` is reachable and then proxy requests to it. If you specify values for both `command` and `targetPort`, `framework` must be `#custom`.",
@@ -635,25 +640,27 @@
           "description": "Secret used to verify tokens for JWT-based redirects.",
           "type": "string"
         },
+        "envFiles": {
+          "title": "Dotenv files",
+          "description": "List of dotenv files to consider loading. Defaults to `.env.development.local, .env.local, .env.development, .env` in this order.",
+          "type": "array",
+          "default": [".env.development.local", ".env.local", ".env.development", ".env"],
+          "items": {
+            "title": "Filename",
+            "description": "The name of the dotenv file.",
+            "type": "string"
+          }
+        },
         "autoLaunch": {
-          "title": "Publish path",
+          "title": "Automatically launch browser",
           "description": "Boolean value that determines whether Netlify Dev launches the local server address in your browser.",
           "type": "boolean"
         },
         "framework": {
-          "title": "Publish path",
-          "description": "Setting to use if a project is detected incorrectly, flagged by multiple detectors, or requires a `command` and `targetPort`.",
+          "title": "Framework",
+          "description": "Setting to use if a project is detected incorrectly, flagged by multiple detectors, or requires a `command` and `targetPort`. Possible values are `#auto`, `#static`, `#custom` or a framework name.",
           "type": "string",
-          "enum": ["#auto", "#static", "#custom"],
-          "x-taplo": {
-            "docs": {
-              "enumValues": [
-                "Default, tests all available detectors.",
-                "Use only a static file server.",
-                "Use the `command` value to run an app server and the `targetPort` value to connect to it. Required if `command` and `targetPort` are both set."
-              ]
-            }
-          }
+          "default": "#auto"
         },
         "https": {
           "title": "HTTPS",

packages/config-schema/tests/fixtures/dev-errors/snapshot.snap

@@ -28,26 +28,22 @@
       "schemaPath": "#/properties/dev/properties/command/type",
     },
     {
-      "instancePath": "/dev/framework",
+      "instancePath": "/dev/envFiles",
       "keyword": "type",
-      "message": "must be string",
+      "message": "must be array",
       "params": {
-        "type": "string",
+        "type": "array",
       },
-      "schemaPath": "#/properties/dev/properties/framework/type",
+      "schemaPath": "#/properties/dev/properties/envFiles/type",
     },
     {
       "instancePath": "/dev/framework",
-      "keyword": "enum",
-      "message": "must be equal to one of the allowed values",
+      "keyword": "type",
+      "message": "must be string",
       "params": {
-        "allowedValues": [
-          "#auto",
-          "#static",
-          "#custom",
-        ],
+        "type": "string",
       },
-      "schemaPath": "#/properties/dev/properties/framework/enum",
+      "schemaPath": "#/properties/dev/properties/framework/type",
     },
     {
       "instancePath": "/dev/functionsPort",
@@ -121,6 +117,15 @@
       },
       "schemaPath": "#/properties/dev/properties/publish/type",
     },
+    {
+      "instancePath": "/dev/staticServerPort",
+      "keyword": "type",
+      "message": "must be number",
+      "params": {
+        "type": "number",
+      },
+      "schemaPath": "#/properties/dev/properties/staticServerPort/type",
+    },
     {
       "instancePath": "/dev/targetPort",
       "keyword": "type",

packages/config-schema/tests/fixtures/dev-errors/test.toml

@@ -3,12 +3,14 @@ command = 1
 port = "string"
 targetPort = "8000"
 functionsPort = "8000"
+staticServerPort = "5858"
 publish = 1
 jwtRolePath = 1
 jwtSecret = 1
 autoLaunch = 1
 framework = 1
 other = 1
+envFiles = 1
 [dev.https]
 certFile = 1
 keyFile = 1

packages/config-schema/tests/fixtures/dev-errors2/snapshot.snap

@@ -1,5 +1,14 @@
 {
   "errors": [
+    {
+      "instancePath": "/dev/envFiles/0",
+      "keyword": "type",
+      "message": "must be string",
+      "params": {
+        "type": "string",
+      },
+      "schemaPath": "#/properties/dev/properties/envFiles/items/type",
+    },
     {
       "instancePath": "/dev/https",
       "keyword": "required",

packages/config-schema/tests/fixtures/dev-errors2/test.toml

@@ -1,3 +1,4 @@
 [dev]
+envFiles = [1]
 [dev.https]
 certFile = "cert.pem"

packages/config-schema/tests/fixtures/dev-pass/test.toml

@@ -3,11 +3,13 @@ command = "yarn start"
 port = 8888
 targetPort = 3000
 functionsPort = 3000
+staticServerPort = 5858
 publish = "dist"
 jwtRolePath = "app_metadata.authorization.roles"
 jwtSecret = "MY_JWT_SECRET_VALUE"
 autoLaunch = true
 framework = "#custom"
+envFiles = [".env", ".env.local"]
 [dev.https]
 certFile = "cert.pem"
 keyFile = "key.pem"