fix: force default region when using the legacy api

Author: mrstork

packages/build/src/plugins_core/blobs_upload/index.ts

@@ -50,7 +50,7 @@ const coreStep: CoreStepFunction = async function ({
   // If using the deploy config API or the Frameworks API, configure the store
   // to use the region that was configured for the deploy. We don't do it for
   // the legacy file-based upload API since that would be a breaking change.
-  if (blobs.apiVersion > 1) {
+  if (blobs.apiVersion === 1) {
     storeOpts.region = 'us-east-2'
   }
 

packages/build/src/plugins_core/dev_blobs_upload/index.ts

@@ -51,7 +51,7 @@ const coreStep: CoreStepFunction = async function ({
   // If using the deploy config API or the Frameworks API, configure the store
   // to use the region that was configured for the deploy. We don't do it for
   // the legacy file-based upload API since that would be a breaking change.
-  if (blobs.apiVersion > 1) {
+  if (blobs.apiVersion === 1) {
     storeOpts.region = 'us-east-2'
   }
 

packages/build/tests/blobs_upload/tests.js

@@ -87,13 +87,13 @@ test.serial('Blobs upload step uploads files to deploy store (legacy API)', asyn
   t.true(success)
   t.is(t.context.blobRequests.set.length, 6)
 
-  const regionRequests = t.context.blobRequests.set.filter((urlPath) => {
+  const defaultRegionRequests = t.context.blobRequests.set.filter((urlPath) => {
     const url = new URL(urlPath, 'http://localhost')
 
-    return url.searchParams.has('region')
+    return url.searchParams.get('region') === 'us-east-2'
   })
 
-  t.is(regionRequests.length, 3)
+  t.is(defaultRegionRequests.length, 3)
 
   const storeOpts = { deployID: 'abc123', siteID: 'test', token: TOKEN }
   if (semver.lt(nodeVersion, '18.0.0')) {
@@ -172,7 +172,7 @@ test.serial('Blobs upload step uploads files to deploy store', async (t) => {
     return url.searchParams.get('region') === 'auto'
   })
 
-  t.is(regionAutoRequests.length, 0)
+  t.is(regionAutoRequests.length, 3)
 
   const storeOpts = { deployID: 'abc123', siteID: 'test', token: TOKEN }
   if (semver.lt(nodeVersion, '18.0.0')) {