Skip to content

Commit 2c62a0c

Browse files
committed
Fix histogram timing metrics
1 parent 83b4d80 commit 2c62a0c

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

metrics/transport/signalfx.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,15 @@ func (t *SFXTransport) Queue(m *metrics.RawMetric) error {
6161
return err
6262
}
6363

64+
if m.Type == metrics.TimerType {
65+
if err := t.recordTimer(m, p.Dimensions); err != nil {
66+
return errors.Wrap(err, "error recording timer to histogram")
67+
}
68+
if t.disableTimerCounters {
69+
return nil
70+
}
71+
}
72+
6473
t.statLock.Lock()
6574
defer t.statLock.Unlock()
6675

@@ -75,10 +84,8 @@ func (t *SFXTransport) Publish(m *metrics.RawMetric) error {
7584
}
7685

7786
if m.Type == metrics.TimerType {
78-
if t.reportDelay > 0 {
79-
if err := t.recordTimer(m, p.Dimensions); err != nil {
80-
return errors.Wrap(err, "error recording timer to histogram")
81-
}
87+
if err := t.recordTimer(m, p.Dimensions); err != nil {
88+
return errors.Wrap(err, "error recording timer to histogram")
8289
}
8390
if t.disableTimerCounters {
8491
return nil

0 commit comments

Comments
 (0)