Skip to content

Commit 74c4816

Browse files
authored
Fix tests around status code in tracing (#201)
1 parent 03d1775 commit 74c4816

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

router/router_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package router
33
import (
44
"net/http"
55
"net/http/httptest"
6+
"strconv"
67
"testing"
78

89
"github.com/opentracing/opentracing-go"
@@ -118,7 +119,7 @@ func TestTracing(t *testing.T) {
118119
if assert.Equal(t, 1, len(spans)) {
119120
assert.Equal(t, "some-service", spans[0].Tag(ext.ServiceName))
120121
assert.Equal(t, scene.resourceName, spans[0].Tag(ext.ResourceName))
121-
assert.Equal(t, http.StatusOK, spans[0].Tag(ext.HTTPCode))
122+
assert.Equal(t, strconv.Itoa(http.StatusOK), spans[0].Tag(ext.HTTPCode))
122123
}
123124
})
124125
}

tracing/req_tracer_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"fmt"
55
"net/http"
66
"net/http/httptest"
7+
"strconv"
78
"testing"
89

910
"github.com/opentracing/opentracing-go"
@@ -87,6 +88,6 @@ func TestTracerSpans(t *testing.T) {
8788
assert.Equal(t, t.Name(), span.Tag(ext.ServiceName))
8889
assert.Equal(t, "some_resource", span.Tag(ext.ResourceName))
8990
assert.Equal(t, http.MethodGet, span.Tag(ext.HTTPMethod))
90-
assert.Equal(t, http.StatusOK, span.Tag(ext.HTTPCode))
91+
assert.Equal(t, strconv.Itoa(http.StatusOK), span.Tag(ext.HTTPCode))
9192
assert.Equal(t, rt.RequestID, span.Tag("http.request_id"))
9293
}

0 commit comments

Comments
 (0)