feat: Add support for IntVariation feature flags (#333)

Author: j4mcs

featureflag/featureflag.go

@@ -21,6 +21,9 @@ type Client interface {
 	Variation(key, defaultVal, userID string, attrs ...Attr) string
 	VariationUser(key string, defaultVal string, user lduser.User) string
 
+	Int(key string, defaultVal int, userID string, attrs ...Attr) int
+	IntUser(key string, defaultVal int, user lduser.User) int
+
 	AllEnabledFlags(key string) []string
 	AllEnabledFlagsUser(key string, user lduser.User) []string
 }
@@ -91,6 +94,19 @@ func (c *ldClient) VariationUser(key string, defaultVal string, user lduser.User
 	return res
 }
 
+func (c *ldClient) Int(key string, defaultValue int, userID string, attrs ...Attr) int {
+	return c.IntUser(key, defaultValue, c.userWithAttrs(userID, attrs))
+}
+
+func (c *ldClient) IntUser(key string, defaultVal int, user lduser.User) int {
+	res, err := c.IntVariation(key, user, defaultVal)
+	if err != nil {
+		c.log.WithError(err).WithField("key", key).Error("Failed to load feature flag")
+	}
+	// DefaultValue will be returned if IntVariation returns an error
+	return res
+}
+
 func (c *ldClient) AllEnabledFlags(key string) []string {
 	return c.AllEnabledFlagsUser(key, lduser.NewUser(key))
 }

featureflag/featureflag_test.go

@@ -23,6 +23,7 @@ func TestOfflineClient(t *testing.T) {
 
 	require.False(t, client.Enabled("notset", "12345"))
 	require.Equal(t, "foobar", client.Variation("notset", "foobar", "12345"))
+	require.Equal(t, 3, client.Int("noset", 3, "12345"))
 }
 
 func TestMockClient(t *testing.T) {
@@ -35,6 +36,10 @@ func TestMockClient(t *testing.T) {
 			"FOO":  "BAR",
 			"BLAH": "FOOBAR",
 		},
+		IntVars: map[string]int{
+			"FOO":  4,
+			"BLAH": 7,
+		},
 	}
 
 	require.True(t, mock.Enabled("FOO", "12345"))
@@ -43,6 +48,9 @@ func TestMockClient(t *testing.T) {
 
 	require.Equal(t, "BAR", mock.Variation("FOO", "DFLT", "12345"))
 	require.Equal(t, "DFLT", mock.Variation("FOOBAR", "DFLT", "12345"))
+
+	require.Equal(t, 4, mock.Int("FOO", 2, "12345"))
+	require.Equal(t, 2, mock.Int("FOOBAR", 2, "12345"))
 }
 
 func TestAllEnabledFlags(t *testing.T) {

featureflag/mock.go

@@ -7,6 +7,7 @@ import (
 type MockClient struct {
 	BoolVars   map[string]bool
 	StringVars map[string]string
+	IntVars    map[string]int
 }
 
 var _ Client = MockClient{}
@@ -31,6 +32,18 @@ func (c MockClient) VariationUser(key string, defaultVal string, _ lduser.User)
 	return res
 }
 
+func (c MockClient) Int(key string, defaultVal int, userID string, _ ...Attr) int {
+	return c.IntUser(key, defaultVal, lduser.NewUser(userID))
+}
+
+func (c MockClient) IntUser(key string, defaultVal int, _ lduser.User) int {
+	res, ok := c.IntVars[key]
+	if !ok {
+		return defaultVal
+	}
+	return res
+}
+
 func (c MockClient) AllEnabledFlags(key string) []string {
 	return c.AllEnabledFlagsUser(key, lduser.NewUser(key))
 }