HealthCheck middleware only handles non-nil errors

Sergio Moya · Sergio Moya · commit ea10ecb2f706 · 2019-08-22T13:20:19.000+02:00
diff --git a/router/middleware.go b/router/middleware.go
@@ -87,7 +87,9 @@ func HealthCheck(route string, f APIHandler) Middleware {
 				w.WriteHeader(http.StatusOK)
 				return
 			}
-			HandleError(f(w, r), w, r)
+			if err := f(w, r); err != nil {
+				HandleError(f(w, r), w, r)
+			}
 			return
 		}
 		next.ServeHTTP(w, r)

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,9 @@ func HealthCheck(route string, f APIHandler) Middleware {`
`87`	`87`	`w.WriteHeader(http.StatusOK)`
`88`	`88`	`return`
`89`	`89`	`}`
`90`		`- HandleError(f(w, r), w, r)`
	`90`	`+ if err := f(w, r); err != nil {`
	`91`	`+ HandleError(f(w, r), w, r)`
	`92`	`+ }`
`91`	`93`	`return`
`92`	`94`	`}`
`93`	`95`	`next.ServeHTTP(w, r)`