Skip to content

FastqToBam with a external UMIs fastq #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
migrau opened this issue Nov 3, 2022 · 5 comments
Closed

FastqToBam with a external UMIs fastq #12

migrau opened this issue Nov 3, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@migrau
Copy link

migrau commented Nov 3, 2022

Description of feature

Is it possible to include a 3rd fastq file including only the UMIs, for the FastqToBam step? What I normally do is:

fgbio --compression 1 --async-io FastqToBam --input {input.fqR1} {input.fqR2} {input.umifq} --read-structures +T +T +M --sample {params.samplename} --library {params.samplename} --output {output}

Many thanks, @nh13! Very exciting seeing a nf-core pipeline for fgbio.

@migrau migrau added the enhancement New feature or request label Nov 3, 2022
@adamrtalbot
Copy link

See #11 !

@adamrtalbot
Copy link

One thing we need to do is add an example UMI FASTQ file to https://github.com/nf-core/test-datasets for testing purposes.

@nh13 nh13 added the good first issue Good for newcomers label Feb 15, 2023
@nh13
Copy link
Member

nh13 commented May 15, 2024

It would be great to support any subset of the standard four reads that can be generated in a paired end library:

  1. index1/i7
  2. index2/i5
  3. read1/R1
  4. read2/R2

The UMI could be in any of these reads, and FastqToBam would be able to handle it.

@nh13
Copy link
Member

nh13 commented May 16, 2024

See #38

@nh13
Copy link
Member

nh13 commented May 21, 2024

Done!

@nh13 nh13 closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants