Skip to content

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Oct 9, 2025

Proposed changes

This PR updates mainline NGINX to 1.29.2 and NJS to 0.9.3. It also updates the mainline NGINX Debian base image to trixie, replaces the mainline NGINX Debian mips64le arch with riscv64 given the new arches supported by trixie.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run the update.sh script and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • I have tested that the NGINX Docker unprivileged image builds and runs correctly on all supported architectures on an unprivileged environment (check out the README for more details)
  • I have updated any relevant documentation (README.md)

* Update mainline NGINX Debian base image to `trixie`
* Replace mainline NGINX Debian `mips64le` arch with `riscv64` given the new arches supported by `trixie`
* Update NJS to 0.9.3
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 12:09
@alessfg alessfg requested a review from a team as a code owner October 9, 2025 12:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mainline NGINX Docker images to version 1.29.2 and NJS to 0.9.3, while migrating the Debian base image from bookworm to trixie. The update also replaces the mips64le architecture with riscv64 to align with the new architectures supported by Debian trixie.

  • Updates NGINX mainline version from 1.29.1 to 1.29.2
  • Updates NJS version from 0.9.1 to 0.9.3
  • Migrates Debian base image from bookworm to trixie
  • Replaces mips64le architecture with riscv64 in CI workflow

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
update.sh Updates version variables and package checksums for NGINX and NJS
mainline/debian/Dockerfile Updates base image, version variables, and repository references
mainline/debian-perl/Dockerfile Updates base image reference and repository URLs
mainline/debian-otel/Dockerfile Updates base image reference and repository URLs
mainline/alpine/Dockerfile Updates base image reference and NJS version
mainline/alpine-slim/Dockerfile Updates NGINX version and package checksum
mainline/alpine-perl/Dockerfile Updates base image reference and package checksum
mainline/alpine-otel/Dockerfile Updates base image reference and package checksum
.github/workflows/debian-mainline.yml Replaces mips64le with riscv64 architecture

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alessfg alessfg self-assigned this Oct 9, 2025
@alessfg alessfg added the enhancement New feature or request label Oct 9, 2025
@alessfg
Copy link
Member Author

alessfg commented Oct 9, 2025

The build is failing due to how the pipeline works. Since the first builds in the sequence did succeed, the rest should work too once the images are actually pushed.

Copy link
Member

@thresheek thresheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, and I'm trusting you on the pipelines part :)

@alessfg alessfg merged commit 8be5c6f into main Oct 10, 2025
16 of 19 checks passed
@alessfg alessfg deleted the update-nginx branch October 10, 2025 13:27
alessfg added a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants