Merge pull request #26 from nik01010/rel/v1_1_1

Version 1.1.1

Author: nik01010

DESCRIPTION

@@ -1,12 +1,12 @@
 Package: dashboardthemes
 Type: Package
-Title: Customise the Appearance of Shiny Dashboard Applications using Themes
-Version: 1.1.0
+Title: Customise the Appearance of 'shinydashboard' Applications using Themes
+Version: 1.1.1
 Authors@R: person("Nik", "Lilovski", email = "nik.lilovski@outlook.com",
                   role = c("aut", "cre"))
 Maintainer: Nik Lilovski <nik.lilovski@outlook.com>
 Description: Allows manual creation of themes and logos to be used in
-    applications created using the shinydashboard package. Removes the need to
+    applications created using the 'shinydashboard' package. Removes the need to
     change the underlying css code by wrapping it into a set of convenient R
     functions.
 URL: https://github.com/nik01010/dashboardthemes

NEWS.md

@@ -1,5 +1,9 @@
 ### dashboardthemes ----------------------------------------
 
+### v1.1.1
+* Updated DESCRIPTION file to use preferred Title and Description formatting.
+* Updated function examples to use \donttest{} instead of \dontrun{} tags.
+
 ### v1.1.0
 * Breaking changes:
   - The boe_website theme has been discontinued, please use flat_red instead.

R/CreateCss_cssGradientThreeColors.R

@@ -12,7 +12,7 @@
 #'
 #' @return CSS code. Gradient with three colors.
 #' @examples
-#' \dontrun{
+#' \donttest{
 #' cssGradientThreeColors(
 #'   direction = "right"
 #'   ,colorStart = "rgba(44,222,235,1)"

R/CreateLogo_shinyDashboardLogo.R

@@ -9,13 +9,13 @@
 #'
 #' @return HTML code. Logo for shinydashboard's sidebar.
 #' @examples
-#' \dontrun{
-#' ...
+#' \donttest{
+#' #...
 #' ### ui
-#' ui <- dashboardPage(
+#' #ui <- dashboardPage(
 #'
 #'   ### ui header
-#'   dashboardHeader(
+#'   #dashboardHeader(
 #'
 #'     ### changing logo
 #'     title = shinyDashboardLogo(
@@ -24,7 +24,7 @@
 #'       mainText = "App",
 #'       badgeText = "v1.1"
 #'     )
-#'     ...
+#'     #...
 #' }
 #' @seealso \code{\link{shinyDashboardLogoDIY}, \link{shinyDashboardThemes}}
 #' @note This logo design was inspired from \url{http://www.dataseries.org/}.

R/CreateLogo_shinyDashboardLogoDIY.R

@@ -13,7 +13,7 @@
 #'
 #' @return HTML code. Logo for shinydashboard's sidebar.
 #' @examples
-#' \dontrun{
+#' \donttest{
 #' customLogo <- shinyDashboardLogoDIY(
 #'   boldText = "SD"
 #'   ,mainText = "Themes"

R/CreateTheme_shinyDashboardThemeDIY.R

@@ -84,7 +84,7 @@
 #'
 #' @return CSS code. Theme for a shinydashboard application.
 #' @examples
-#' \dontrun{
+#' \donttest{
 #' customTheme <- shinyDashboardThemeDIY(
 #'
 #'   ### general

R/CreateTheme_shinyDashboardThemes.R

@@ -17,20 +17,20 @@
 #'
 #' @return CSS code. Theme for shinydashboard.
 #' @examples
-#' \dontrun{
-#' ...
+#' \donttest{
+#' #...
 #' ### ui body
-#' dashboardBody(
+#' #dashboardBody(
 #'
 #'   ### changing theme
 #'   shinyDashboardThemes(
 #'     theme = "blue_gradient"
 #'   )
 #'
 #'   ### ui tabs
-#'   ,tabItems(
-#'     tabItem(
-#'       ...
+#'   #,tabItems(
+#'   #  tabItem(
+#'   #    ...
 #' }
 #' @seealso \code{\link{shinyDashboardThemeDIY}, \link{shinyDashboardLogo}}
 #' @export

cran-comments.md

@@ -8,5 +8,25 @@
 * For test coverage reports, see https://codecov.io/gh/nik01010/dashboardthemes
 
 ## Submission comments
+2020-07-01
 * No errors, warnings or notes.
 * This package has been available on GitHub since early 2018 and has a relatively strong following, v1.1.0 is mostly just a back-end refactor. For further information, see the NEWS release notes (https://github.com/nik01010/dashboardthemes).
+
+## Reviewer comments
+2020-07-03 Swetlana Herbrandt
+* Thanks, please write package names, software names and API names in single quotes (e.g. 'shiny', 'shinydashboard') in Title and Description.
+* Please replace \dontrun{} by \donttest{} or if(interactive()){} in your Rd-files.
+* Please fix and resubmit.
+
+
+# v1.1.1
+## Test environments
+* Windows 10, R 4.0.2 (on local PC).
+* Linux Xenial Ubuntu 16.04.6 LTS, R release, oldrel, devel (on Travis CI).
+* Mac OS X 10.13.6, R release, oldrel (on Travis CI).
+
+## Submission comments
+2020-07-03
+* No errors, warnings or notes. Addressed reviewer comments:
+* Updated DESCRIPTION file to use preferred Title and Description formatting.
+* Updated function examples to use \donttest{} instead of \dontrun{} tags.