Skip to content

Commit f77b010

Browse files
committed
fix: direct http server backend logs to file instead of stderr
1 parent b8a8e90 commit f77b010

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## v1.0-alpha9
4+
5+
- Prevent http servers backends from logging to stdout or stderr
6+
37
## v1.0-alpha8
48

59
- Add a new service type: embedded_http_proxy

internal/service/server_type_httpproxy.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ package service
22

33
import (
44
"github.com/elazarl/goproxy"
5+
"github.com/sirupsen/logrus"
56
"github.com/ztrue/tracerr"
7+
"log"
68
"net"
79
"net/http"
810
)
@@ -13,9 +15,12 @@ type httpServer struct {
1315
}
1416

1517
func CreateHttpServer() (Server, error) {
18+
server := goproxy.NewProxyHttpServer()
19+
server.Logger = logrus.StandardLogger()
1620
proxy := httpServer{
1721
server: &http.Server{
18-
Handler: goproxy.NewProxyHttpServer(),
22+
Handler: server,
23+
ErrorLog: log.New(logrus.StandardLogger().Writer(), "[http-server] ", log.LstdFlags),
1924
},
2025
}
2126
return &proxy, nil

internal/service/server_type_webdav.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"github.com/sirupsen/logrus"
55
"github.com/ztrue/tracerr"
66
"golang.org/x/net/webdav"
7+
"log"
78
"net"
89
"net/http"
910
)
@@ -28,7 +29,8 @@ func CreateWebdavServer() (Server, error) {
2829
},
2930
}
3031
server := http.Server{
31-
Handler: &handler,
32+
Handler: &handler,
33+
ErrorLog: log.New(logrus.StandardLogger().Writer(), "[webdav-server] ", log.LstdFlags),
3234
}
3335
return &WebdavServer{server: &server}, nil
3436
}

0 commit comments

Comments
 (0)