demo: remove backward compat shim and HMR guards; update imports

- Delete src/lib/Demo.ts compatibility shim
- Update imports to use src/lib/demo
- Remove hot-reload duplicate-init and route dedupe in demo/index.ts
- Keep service-worker update behavior unchanged (non-demo)

Author: onmax

src/components/layouts/Sidebar.vue

@@ -185,20 +185,20 @@
         <div class="flex-grow"></div>
 
         <AccountMenu
-            :class="{'active': $route.name === 'root'}"
+            :class="{'active': $route.name === RouteName.Root}"
             @click="navigateTo('/')"/>
 
         <button
             class="network reset flex-row"
-            :class="{'active': $route.name === 'network'}"
+            :class="{'active': $route.name === RouteName.Network}"
             @click="navigateTo('/network')"
         >
             <ConsensusIcon/>
             <span class="label">{{ $t('Network') }}</span>
         </button>
         <button
             class="settings reset flex-row"
-            :class="{'active': $route.name === 'settings'}"
+            :class="{'active': $route.name === RouteName.Settings}"
             @click="navigateTo('/settings')"
         >
             <GearIcon/>
@@ -213,7 +213,7 @@ import { defineComponent, ref, computed } from '@vue/composition-api';
 import { SwapAsset } from '@nimiq/fastspot-api';
 import { GearIcon, Tooltip, InfoCircleIcon } from '@nimiq/vue-components';
 import { RouteName, useRouter } from '@/router';
-import { checkIfDemoIsActive } from '@/lib/Demo';
+import { checkIfDemoIsActive } from '@/lib/demo';
 import AnnouncementBox from '../AnnouncementBox.vue';
 import AccountMenu from '../AccountMenu.vue';
 import PriceChart, { TimeRange } from '../PriceChart.vue';
@@ -384,6 +384,7 @@ export default defineComponent({
 
         return {
             CryptoCurrency,
+            RouteName,
             navigateTo,
             resetState,
             isTestnet,
@@ -401,7 +402,6 @@ export default defineComponent({
             updateAvailable,
             hideTooltips,
             openModal,
-            RouteName,
             SellProvider,
             enabledSellProviders,
             sellEnabled,

src/components/modals/demos/DemoModalBuy.vue

@@ -69,7 +69,7 @@ import Modal from '@/components/modals/Modal.vue';
 import { useAccountStore } from '@/stores/Account';
 import { useFiatStore } from '@/stores/Fiat';
 import { FIAT_CURRENCIES_OFFERED, CryptoCurrency } from '@/lib/Constants';
-import { dangerouslyInsertFakeBuyNimTransaction } from '@/lib/Demo';
+import { dangerouslyInsertFakeBuyNimTransaction } from '@/lib/demo';
 import { useRouter } from '@/router';
 import BankIconButton from '@/components/BankIconButton.vue';
 import { useAddressStore } from '@/stores/Address';

src/hub.ts

@@ -18,7 +18,7 @@ import type { PlainTransactionDetails } from '@nimiq/core';
 import type { RequestBehavior, BehaviorType } from '@nimiq/hub-api/dist/src/RequestBehavior.d';
 import type { ForwardRequest } from '@opengsn/common/dist/EIP712/ForwardRequest';
 import Config from 'config';
-import { DemoHubApi, checkIfDemoIsActive } from '@/lib/Demo';
+import { DemoHubApi, checkIfDemoIsActive } from '@/lib/demo';
 import { useAccountStore, AccountInfo, AccountType } from './stores/Account';
 import { useAddressStore, AddressInfo, AddressType } from './stores/Address';
 import { useBtcAddressStore, BtcAddressInfo } from './stores/BtcAddress';

src/lib/Demo.ts

@@ -52,8 +52,6 @@ let demoRouter: VueRouter;
 // Simple state tracking for current modal
 let currentModal: DemoFlowType = 'idle';
 
-// Track if demo has been initialized to prevent duplicate initialization
-let isInitialized = false;
 
 // Demo modal imports for dynamic loading
 const DemoFallbackModal = () =>
@@ -78,12 +76,6 @@ export function dangerouslyInitializeDemo(router: VueRouter): void {
         return;
     }
 
-    // Prevent duplicate initialization during hot reload
-    if (isInitialized && demoRouter === router) {
-        console.debug('[Demo] Demo already initialized, skipping duplicate initialization.');
-        return;
-    }
-
     console.warn('[Demo] Initializing demo environment...');
 
     demoRouter = router;
@@ -114,8 +106,6 @@ export function dangerouslyInitializeDemo(router: VueRouter): void {
     // Send initial ready message to parent frame
     sendInitialReadyMessage();
 
-    // Mark as initialized
-    isInitialized = true;
 }
 
 /**
@@ -148,12 +138,6 @@ function sendInitialReadyMessage(): void {
  * Adds routes pointing to our demo modals.
  */
 function addDemoModalRoutes(): void {
-    // Use a flag attached to the router instance to track if routes were added
-    // This persists across hot reloads since the router instance persists
-    if ((demoRouter as any)._demoRoutesAdded) {
-        console.debug('[Demo] Routes already added to router, skipping duplicate registration');
-        return;
-    }
 
     // Import layout components for explicit inclusion
     const AccountOverview = () => import(/* webpackChunkName: "account-overview" */ '@/components/layouts/AccountOverview.vue');
@@ -184,8 +168,6 @@ function addDemoModalRoutes(): void {
         meta: { column: Columns.DYNAMIC },
     });
 
-    // Mark routes as added on the router instance
-    (demoRouter as any)._demoRoutesAdded = true;
     console.debug('[Demo] Demo routes added successfully');
 }
 

src/lib/demo/index.ts

@@ -8,7 +8,7 @@ import { init as initFastspotApi } from '@nimiq/fastspot-api';
 import VuePortal from '@linusborg/vue-simple-portal';
 
 import App from './App.vue';
-import { dangerouslyInitializeDemo } from './lib/Demo';
+import { dangerouslyInitializeDemo } from './lib/demo';
 import { useAccountStore } from './stores/Account';
 import { useFiatStore } from './stores/Fiat';
 import { useSettingsStore } from './stores/Settings';

src/main-demo.ts

@@ -3,7 +3,7 @@ import { ref, watch } from '@vue/composition-api';
 import { SignedTransaction } from '@nimiq/hub-api';
 import type { Client, PlainStakingContract, PlainTransactionDetails } from '@nimiq/core';
 
-import { checkIfDemoIsActive } from '@/lib/Demo';
+import { checkIfDemoIsActive } from '@/lib/demo';
 import { useAddressStore } from './stores/Address';
 import { useTransactionsStore, TransactionState } from './stores/Transactions';
 import { useNetworkStore } from './stores/Network';