fix(client): Add support https if Device behind NAT/Proxy & Change service_path fallback for Search service

Author: kaburagisec

onvif/client.py

@@ -153,7 +153,7 @@ def _get_xaddr(self, service_name: str, service_path: str):
             connect_port = self.common_args["port"]
             # if host/port differ, rewrite XAddr to use connection values
             if (device_host != connect_host) or (device_port != connect_port):
-                protocol = parsed.scheme
+                protocol = "https" if self.common_args["use_https"] else "http"
                 new_netloc = f"{connect_host}:{connect_port}"
                 rewritten = urlunparse((protocol, new_netloc, parsed.path, "", "", ""))
                 return rewritten

onvif/services/search.py

@@ -10,7 +10,7 @@ def __init__(self, xaddr=None, **kwargs):
         self.operator = ONVIFOperator(
             definition["path"],
             binding=f"{{{definition['namespace']}}}{definition['binding']}",
-            service_path="Search",  # fallback
+            service_path="SearchRecording",  # fallback
             xaddr=xaddr,
             **kwargs,
         )