Skip to content

Commit 07d0a79

Browse files
authored
Remove incorrect chord shapes for D7 and Dm7 (#37)
1 parent 120d0ed commit 07d0a79

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

src/chord/chord_shape.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,12 @@ impl ChordShapeSet {
118118
ChordShape::new("A", [0, 1, 0, 0], ["m7", "M3", "P5", "P1"]),
119119
ChordShape::new("G", [0, 2, 1, 2], ["P1", "P5", "m7", "M3"]),
120120
ChordShape::new("E", [1, 2, 0, 2], ["M3", "m7", "P1", "P5"]),
121-
ChordShape::new("D", [2, 0, 2, 0], ["P5", "m7", "M3", "P5"]),
122121
],
123122
MinorSeventh => vec![
124123
ChordShape::new("C#", [1, 1, 0, 2], ["P5", "P1", "m3", "m7"]),
125124
ChordShape::new("A", [0, 0, 0, 0], ["m7", "m3", "P5", "P1"]),
126125
ChordShape::new("G", [0, 2, 1, 1], ["P1", "P5", "m7", "m3"]),
127126
ChordShape::new("E", [0, 2, 0, 2], ["m3", "m7", "P1", "P5"]),
128-
ChordShape::new("D", [2, 0, 1, 0], ["P5", "m7", "m3", "P5"]),
129127
],
130128
MajorSeventh => vec![
131129
ChordShape::new("C", [0, 0, 0, 2], ["P5", "P1", "M3", "M7"]),

tests/ukebox.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,6 @@ fn test_dominant_seventh_chords(tuning: Tuning) -> Result<(), Box<dyn std::error
472472
TestConfig::new(ct, 9, 2, [0, 1, 0, 0], tuning),
473473
TestConfig::new(ct, 7, 1, [0, 2, 1, 2], tuning),
474474
TestConfig::new(ct, 4, 1, [1, 2, 0, 2], tuning),
475-
TestConfig::new(ct, 2, 1, [2, 0, 2, 0], tuning),
476475
];
477476

478477
run_tests(test_configs)
@@ -492,7 +491,6 @@ fn test_minor_seventh_chords(tuning: Tuning) -> Result<(), Box<dyn std::error::E
492491
TestConfig::new(ct, 9, 2, [0, 0, 0, 0], tuning),
493492
TestConfig::new(ct, 7, 1, [0, 2, 1, 1], tuning),
494493
TestConfig::new(ct, 4, 1, [0, 2, 0, 2], tuning),
495-
TestConfig::new(ct, 2, 1, [2, 0, 1, 0], tuning),
496494
];
497495

498496
run_tests(test_configs)

0 commit comments

Comments
 (0)