Skip to content

Commit fd93513

Browse files
noeddlnoeddl
authored
Release 0.4.0 (#38)
* Update dependencies * Replace rstest_parametrize with rstest * Update integration test for new version of assert_cmd * Update changelog
1 parent 07d0a79 commit fd93513

File tree

10 files changed

+114
-126
lines changed

10 files changed

+114
-126
lines changed

‎CHANGELOG.md‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
# Changelog
22

3+
## [0.4.0] - 2019-12-23
4+
5+
* Add a bunch of new chord types ([#31](https://github.com/noeddl/ukebox/issues/31)).
6+
* Remove incorrect chord shapes for `D7` and `Dm7` ([#34](https://github.com/noeddl/ukebox/issues/34)).
7+
38
## [0.3.0] - 2019-11-24
49

510
* Set up CI for the repo.
6-
* Add command line option `--tuning` to specify a tuning (`C`, `D` or `G`).
11+
* Add command line option `--tuning` to specify a tuning (`C`, `D` or `G`) ([#1](https://github.com/noeddl/ukebox/issues/1)).
712

813
## [0.2.0] - 2019-10-13
914

‎Cargo.lock‎

Lines changed: 55 additions & 72 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "ukebox"
3-
version = "0.3.0"
3+
version = "0.4.0"
44
authors = ["Anett Seeker"]
55
edition = "2018"
66
license = "MIT OR Apache-2.0"
@@ -18,7 +18,7 @@ regex = "1"
1818
structopt = "0.3"
1919

2020
[dev-dependencies]
21-
assert_cmd = "0.10"
21+
assert_cmd = "0.12"
2222
indoc = "0.3"
2323
predicates = "1"
24-
rstest = "0.3"
24+
rstest = "0.5"

‎src/chord/chord.rs‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -202,9 +202,9 @@ impl FromStr for Chord {
202202
mod tests {
203203
#![allow(clippy::many_single_char_names)]
204204
use super::*;
205-
use rstest::rstest_parametrize;
205+
use rstest::rstest;
206206

207-
#[rstest_parametrize(
207+
#[rstest(
208208
chord,
209209
case("Z"),
210210
case("c"),
@@ -219,7 +219,7 @@ mod tests {
219219
assert!(Chord::from_str(chord).is_err())
220220
}
221221

222-
#[rstest_parametrize(
222+
#[rstest(
223223
chord,
224224
root,
225225
third,
@@ -251,7 +251,7 @@ mod tests {
251251
assert_eq!(c.chord_type, ChordType::Major);
252252
}
253253

254-
#[rstest_parametrize(
254+
#[rstest(
255255
chord,
256256
root,
257257
third,
@@ -283,7 +283,7 @@ mod tests {
283283
assert_eq!(c.chord_type, ChordType::Minor);
284284
}
285285

286-
#[rstest_parametrize(
286+
#[rstest(
287287
chord,
288288
root,
289289
third,
@@ -315,7 +315,7 @@ mod tests {
315315
assert_eq!(c.chord_type, ChordType::SuspendedSecond);
316316
}
317317

318-
#[rstest_parametrize(
318+
#[rstest(
319319
chord,
320320
root,
321321
third,
@@ -347,7 +347,7 @@ mod tests {
347347
assert_eq!(c.chord_type, ChordType::SuspendedFourth);
348348
}
349349

350-
#[rstest_parametrize(
350+
#[rstest(
351351
chord,
352352
root,
353353
third,
@@ -379,7 +379,7 @@ mod tests {
379379
assert_eq!(c.chord_type, ChordType::Augmented);
380380
}
381381

382-
#[rstest_parametrize(
382+
#[rstest(
383383
chord,
384384
root,
385385
third,
@@ -411,7 +411,7 @@ mod tests {
411411
assert_eq!(c.chord_type, ChordType::Diminished);
412412
}
413413

414-
#[rstest_parametrize(
414+
#[rstest(
415415
chord,
416416
root,
417417
third,
@@ -451,7 +451,7 @@ mod tests {
451451
assert_eq!(c.chord_type, ChordType::DominantSeventh);
452452
}
453453

454-
#[rstest_parametrize(
454+
#[rstest(
455455
chord,
456456
root,
457457
third,
@@ -491,7 +491,7 @@ mod tests {
491491
assert_eq!(c.chord_type, ChordType::MinorSeventh);
492492
}
493493

494-
#[rstest_parametrize(
494+
#[rstest(
495495
chord,
496496
root,
497497
third,
@@ -531,7 +531,7 @@ mod tests {
531531
assert_eq!(c.chord_type, ChordType::MajorSeventh);
532532
}
533533

534-
#[rstest_parametrize(
534+
#[rstest(
535535
chord,
536536
root,
537537
third,
@@ -571,7 +571,7 @@ mod tests {
571571
assert_eq!(c.chord_type, ChordType::MinorMajorSeventh);
572572
}
573573

574-
#[rstest_parametrize(
574+
#[rstest(
575575
chord,
576576
root,
577577
third,
@@ -611,7 +611,7 @@ mod tests {
611611
assert_eq!(c.chord_type, ChordType::AugmentedSeventh);
612612
}
613613

614-
#[rstest_parametrize(
614+
#[rstest(
615615
chord,
616616
root,
617617
third,
@@ -651,7 +651,7 @@ mod tests {
651651
assert_eq!(c.chord_type, ChordType::AugmentedMajorSeventh);
652652
}
653653

654-
#[rstest_parametrize(
654+
#[rstest(
655655
chord,
656656
root,
657657
third,
@@ -691,7 +691,7 @@ mod tests {
691691
assert_eq!(c.chord_type, ChordType::DiminishedSeventh);
692692
}
693693

694-
#[rstest_parametrize(
694+
#[rstest(
695695
chord,
696696
root,
697697
third,
@@ -731,7 +731,7 @@ mod tests {
731731
assert_eq!(c.chord_type, ChordType::HalfDiminishedSeventh);
732732
}
733733

734-
#[rstest_parametrize(
734+
#[rstest(
735735
chord,
736736
note,
737737
contains,

‎src/diagram/chord_diagram.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ impl fmt::Display for ChordDiagram {
8989
mod tests {
9090
use super::*;
9191
use indoc::indoc;
92-
use rstest::rstest_parametrize;
92+
use rstest::rstest;
9393
use std::str::FromStr;
9494

95-
#[rstest_parametrize(chord_name, min_fret, tuning, diagram,
95+
#[rstest(chord_name, min_fret, tuning, diagram,
9696
case(
9797
"C",
9898
0,

‎src/diagram/string_diagram.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ impl fmt::Display for StringDiagram {
6060
#[cfg(test)]
6161
mod tests {
6262
use super::*;
63-
use rstest::rstest_parametrize;
63+
use rstest::rstest;
6464
use std::str::FromStr;
6565

66-
#[rstest_parametrize(
66+
#[rstest(
6767
root_name,
6868
base_fret,
6969
fret,

‎src/note/note.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,10 @@ impl Add<Interval> for Note {
142142
#[cfg(test)]
143143
mod tests {
144144
use super::*;
145-
use rstest::rstest_parametrize;
145+
use rstest::rstest;
146146
use Interval::*;
147147

148-
#[rstest_parametrize(
148+
#[rstest(
149149
s,
150150
case("C"),
151151
case("C#"),
@@ -170,7 +170,7 @@ mod tests {
170170
assert_eq!(format!("{}", note), s);
171171
}
172172

173-
#[rstest_parametrize(
173+
#[rstest(
174174
note_name,
175175
interval,
176176
result_name,

‎src/note/pitch_class.rs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,10 @@ impl Sub<Semitones> for PitchClass {
115115
#[cfg(test)]
116116
mod tests {
117117
use super::*;
118-
use rstest::rstest_parametrize;
118+
use rstest::rstest;
119119
use PitchClass::*;
120120

121-
#[rstest_parametrize(
121+
#[rstest(
122122
n,
123123
pitch_class,
124124
case(0, C),
@@ -143,7 +143,7 @@ mod tests {
143143
assert_eq!(PitchClass::from(n), pitch_class);
144144
}
145145

146-
#[rstest_parametrize(
146+
#[rstest(
147147
pitch_class,
148148
n,
149149
result,
@@ -158,7 +158,7 @@ mod tests {
158158
assert_eq!(pitch_class + n, result);
159159
}
160160

161-
#[rstest_parametrize(
161+
#[rstest(
162162
pc1,
163163
pc2,
164164
n,
@@ -171,7 +171,7 @@ mod tests {
171171
assert_eq!(pc1 - pc2, n);
172172
}
173173

174-
#[rstest_parametrize(
174+
#[rstest(
175175
pc1,
176176
n,
177177
pc2,

‎src/note/staff_position.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ impl Add<StaffSteps> for StaffPosition {
5858
#[cfg(test)]
5959
mod tests {
6060
use super::*;
61-
use rstest::rstest_parametrize;
61+
use rstest::rstest;
6262
use StaffPosition::*;
6363

64-
#[rstest_parametrize(
64+
#[rstest(
6565
n,
6666
staff_position,
6767
case(0, CPos),
@@ -76,7 +76,7 @@ mod tests {
7676
assert_eq!(StaffPosition::from(n), staff_position);
7777
}
7878

79-
#[rstest_parametrize(
79+
#[rstest(
8080
staff_position,
8181
n,
8282
result,

0 commit comments

Comments
 (0)