Skip to content

Commit 9c96dca

Browse files
fix(xtask): Fix execute flag escaping. (#163)
`xshell` uses some custom escaping logic under the hood that meant trying to pass two args in a single string didn't work (they end up as one quoted single arg, which `cargo-release` doesn't accept). This commit modifies the flag inclusion logic to instead pass them as a slice, which should expand correctly. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
1 parent a14305c commit 9c96dca

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

xtask/src/release.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,9 @@ impl Step for ReleaseCrate {
345345
let sh = Shell::new()?;
346346
let krate = self.krate.name();
347347
let bump = self.bump.to_string();
348-
let execute = self.execute.then_some("--execute --no-confirm");
348+
349+
let possible_args = ["--execute", "--no-confirm"];
350+
let execute = self.execute.then_some(&possible_args[..]).unwrap_or(&[]);
349351

350352
cmd!(
351353
sh,

0 commit comments

Comments
 (0)