Skip to content

Commit fb3144a

Browse files
fix: improve vmlens handling (#1628)
* fix: for #1611 Only execute concurrent tests with VMLens VMLens test run now takes 4s and there is no risk of hanging tests. The hanging tests was during executing ArchUnitTests with VMLens. Renamed VmLensTest to VmLensCT and added a filter in the VMlens plugin. increased timeout for gherkin tests to 30s from 10s Signed-off-by: ThomasKrieger <thomas.krieger@vmlens.com> * added await in ProviderSteps and removed Awaitility.await() since it is not needed anymore since we wait during the setting of the states Signed-off-by: ThomasKrieger <thomas.krieger@vmlens.com> --------- Signed-off-by: ThomasKrieger <thomas.krieger@vmlens.com>
1 parent 55c344a commit fb3144a

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

pom.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@
196196
<dependency>
197197
<groupId>com.vmlens</groupId>
198198
<artifactId>api</artifactId>
199-
<version>1.2.13</version>
199+
<version>1.2.14</version>
200200
<scope>test</scope>
201201
</dependency>
202202

@@ -348,7 +348,7 @@
348348
</activation>
349349
<build>
350350
<plugins>
351-
<!--<plugin>
351+
<plugin>
352352
<groupId>com.vmlens</groupId>
353353
<artifactId>vmlens-maven-plugin</artifactId>
354354
<version>1.2.14</version>
@@ -359,11 +359,14 @@
359359
<goal>test</goal>
360360
</goals>
361361
<configuration>
362+
<includes>
363+
<include>**/*CT.java</include>
364+
</includes>
362365
<failIfNoTests>true</failIfNoTests>
363366
</configuration>
364367
</execution>
365368
</executions>
366-
</plugin>-->
369+
</plugin>
367370
<plugin>
368371
<artifactId>maven-dependency-plugin</artifactId>
369372
<version>3.8.1</version>

src/test/java/dev/openfeature/sdk/e2e/steps/ProviderSteps.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import io.cucumber.java.en.Given;
2727
import io.cucumber.java.en.Then;
2828
import java.util.Map;
29-
import org.awaitility.Awaitility;
3029

3130
public class ProviderSteps {
3231
private final State state;
@@ -113,19 +112,15 @@ private void setupMockProvider(ErrorCode errorCode, String errorMessage, Provide
113112
switch (providerState) {
114113
case FATAL:
115114
case ERROR:
116-
mockProvider.emitProviderReady(details);
117-
mockProvider.emitProviderError(details);
115+
mockProvider.emitProviderReady(details).await();
116+
mockProvider.emitProviderError(details).await();
118117
break;
119118
case STALE:
120-
mockProvider.emitProviderReady(details);
121-
mockProvider.emitProviderStale(details);
119+
mockProvider.emitProviderReady(details).await();
120+
mockProvider.emitProviderStale(details).await();
122121
break;
123122
default:
124123
}
125-
Awaitility.await().until(() -> {
126-
ProviderState providerState1 = client.getProviderState();
127-
return providerState1 == providerState;
128-
});
129124
}
130125

131126
private void configureMockEvaluations(FeatureProvider mockProvider, ErrorCode errorCode, String errorMessage) {

src/test/java/dev/openfeature/sdk/vmlens/VmLensTest.java renamed to src/test/java/dev/openfeature/sdk/vmlens/VmLensCT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.junit.jupiter.api.BeforeEach;
1919
import org.junit.jupiter.api.Test;
2020

21-
class VmLensTest {
21+
class VmLensCT {
2222
final OpenFeatureAPI api = OpenFeatureAPITestUtil.createAPI();
2323

2424
@BeforeEach

0 commit comments

Comments
 (0)