Skip to content

Commit 78a04ce

Browse files
Update Symfony Messenger instrumentation to use SpanKind::KIND_PRODUCER, SpanKind::KIND_CONSUMER #1314 (#304)
* Update Symfony Messenger instrumentation to use SpanKind::KIND_PRODUCER and KIND_CONSUMER * test file edit to match instrumentation * Send instrumentation updated to KIND_PRODUCER * Test updated
1 parent 67ce817 commit 78a04ce

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Instrumentation/Symfony/src/MessengerInstrumentation.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public static function register(): void
5858
$builder = $instrumentation
5959
->tracer()
6060
->spanBuilder(\sprintf('DISPATCH %s', $messageClass))
61-
->setSpanKind(SpanKind::KIND_INTERNAL)
61+
->setSpanKind(SpanKind::KIND_PRODUCER)
6262
->setAttribute(TraceAttributes::CODE_FUNCTION, $function)
6363
->setAttribute(TraceAttributes::CODE_NAMESPACE, $class)
6464
->setAttribute(TraceAttributes::CODE_FILEPATH, $filename)
@@ -125,7 +125,7 @@ public static function register(): void
125125
$builder = $instrumentation
126126
->tracer()
127127
->spanBuilder(\sprintf('SEND %s', $messageClass))
128-
->setSpanKind(SpanKind::KIND_INTERNAL)
128+
->setSpanKind(SpanKind::KIND_PRODUCER)
129129
->setAttribute(TraceAttributes::CODE_FUNCTION, $function)
130130
->setAttribute(TraceAttributes::CODE_NAMESPACE, $class)
131131
->setAttribute(TraceAttributes::CODE_FILEPATH, $filename)

src/Instrumentation/Symfony/tests/Integration/MessengerInstrumentationTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public function sendDataProvider(): array
157157
[
158158
new SendEmailMessage('Hello Again'),
159159
'SEND OpenTelemetry\Tests\Instrumentation\Symfony\tests\Integration\SendEmailMessage',
160-
SpanKind::KIND_INTERNAL,
160+
SpanKind::KIND_PRODUCER,
161161
[
162162
MessengerInstrumentation::ATTRIBUTE_MESSENGER_TRANSPORT => class_exists('Symfony\Component\Messenger\Transport\InMemory\InMemoryTransport') ? 'Symfony\Component\Messenger\Transport\InMemory\InMemoryTransport' : 'Symfony\Component\Messenger\Transport\InMemoryTransport',
163163
MessengerInstrumentation::ATTRIBUTE_MESSENGER_MESSAGE => 'OpenTelemetry\Tests\Instrumentation\Symfony\tests\Integration\SendEmailMessage',
@@ -172,7 +172,7 @@ public function dispatchDataProvider(): array
172172
[
173173
new SendEmailMessage('Hello Again'),
174174
'DISPATCH OpenTelemetry\Tests\Instrumentation\Symfony\tests\Integration\SendEmailMessage',
175-
SpanKind::KIND_INTERNAL,
175+
SpanKind::KIND_PRODUCER,
176176
[
177177
MessengerInstrumentation::ATTRIBUTE_MESSENGER_BUS => 'Symfony\Component\Messenger\MessageBus',
178178
MessengerInstrumentation::ATTRIBUTE_MESSENGER_MESSAGE => 'OpenTelemetry\Tests\Instrumentation\Symfony\tests\Integration\SendEmailMessage',

0 commit comments

Comments
 (0)