Fix span status for 4XX responses (#290)

alecsammon · web-flow · commit 89117db8d7c7 · 2024-09-04T22:09:50.000+10:00
diff --git a/src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Http/Kernel.php b/src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Http/Kernel.php
@@ -91,7 +91,7 @@ protected function hookHandle(): bool
                 }
 
                 if ($response) {
-                    if ($response->getStatusCode() >= 400) {
+                    if ($response->getStatusCode() >= 500) {
                         $span->setStatus(StatusCode::STATUS_ERROR);
                     }
                     $span->setAttribute(TraceAttributes::HTTP_RESPONSE_STATUS_CODE, $response->getStatusCode());

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ protected function hookHandle(): bool`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`if ($response) {`
`94`		`- if ($response->getStatusCode() >= 400) {`
	`94`	`+ if ($response->getStatusCode() >= 500) {`
`95`	`95`	`$span->setStatus(StatusCode::STATUS_ERROR);`
`96`	`96`	`}`
`97`	`97`	`$span->setAttribute(TraceAttributes::HTTP_RESPONSE_STATUS_CODE, $response->getStatusCode());`