Skip to content

Commit a0d6027

Browse files
Update wordpress span Name to include low cardinal target (#414)
1 parent 27b914a commit a0d6027

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/Instrumentation/Wordpress/composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"open-telemetry/api": "^1.0",
1515
"open-telemetry/sem-conv": "^1.32",
1616
"nyholm/psr7": "^1",
17-
"nyholm/psr7-server": "^1"
17+
"nyholm/psr7-server": "^1",
18+
"psr/http-message": "2.0"
1819
},
1920
"require-dev": {
2021
"friendsofphp/php-cs-fixer": "^3",

src/Instrumentation/Wordpress/src/WordpressInstrumentation.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use function OpenTelemetry\Instrumentation\hook;
1717
use OpenTelemetry\SemConv\TraceAttributes;
1818
use OpenTelemetry\SemConv\Version;
19+
use Psr\Http\Message\ServerRequestInterface;
1920
use Throwable;
2021

2122
/**
@@ -92,7 +93,7 @@ function: 'wp_initial_constants',
9293

9394
$span = $instrumentation
9495
->tracer()
95-
->spanBuilder(sprintf('%s', $request->getMethod()))
96+
->spanBuilder(sprintf('%s %s', $request->getMethod(), self::getScriptNameFromRequest($request)))
9697
->setParent($parent)
9798
->setSpanKind(SpanKind::KIND_SERVER)
9899
->setAttribute(TraceAttributes::URL_FULL, (string) $request->getUri())
@@ -183,4 +184,9 @@ private static function end(?Throwable $exception): void
183184

184185
$span->end();
185186
}
187+
188+
private static function getScriptNameFromRequest(ServerRequestInterface $request): string
189+
{
190+
return $request->getServerParams()['SCRIPT_NAME'] ?? '/';
191+
}
186192
}

0 commit comments

Comments
 (0)